Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases for windows #11

Open
BarbzYHOOL opened this issue Oct 17, 2018 · 5 comments
Open

Releases for windows #11

BarbzYHOOL opened this issue Oct 17, 2018 · 5 comments

Comments

@BarbzYHOOL
Copy link
Contributor

Sorry to spam @svarlamov

You should put the release files for windows in the release section of github!

@svarlamov
Copy link
Member

No problem... I should do that for all of it, but not too familiar with the Github releases setup as we'd have to also add the binaries in addition the source code at the release tag... Is this something that you'd like to contribute to? Would be much appreciated and then we can deprecate the S3-based downloads

@BarbzYHOOL
Copy link
Contributor Author

I never did it either nor used git tags yet :( but you're not forced to make it a hassle, I suppose you just need to upload the binary when you decide to, so basically just upload the actual binaries to github and next time when there is something really major updated

Why? because it's one of the thing people look for when they don't want to compile the src (I myself look if there is any release)

Look, I made a test in 10 seconds lol https://github.com/BarbzYHOOL/fish-msg/releases/tag/1

@BarbzYHOOL
Copy link
Contributor Author

BarbzYHOOL commented Oct 21, 2018

I'm also quite worried about it being on amazon and not github

Even for the linux installer @svarlamov

@BarbzYHOOL
Copy link
Contributor Author

Fixed here f7a9181 ? it gonna be easier to automatically install!

  • now we can watch for new releases on github

@svarlamov
Copy link
Member

So I just checked this and it seems there's an issue following the GitHub S3 redirect to download the files (as GH hosts everything on their S3 anyways). I'll need to look into that prior to updating the readme

@svarlamov svarlamov reopened this Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants