From 38a42c6fe30171a7fdf490105bc258eebb97a03a Mon Sep 17 00:00:00 2001 From: Shyam Jeedigunta Date: Thu, 3 Oct 2024 15:18:45 -0700 Subject: [PATCH] Add a caution note about making apply context bounded --- server/etcdserver/apply/uber_applier.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/server/etcdserver/apply/uber_applier.go b/server/etcdserver/apply/uber_applier.go index 82b7a627669..6a283a9981a 100644 --- a/server/etcdserver/apply/uber_applier.go +++ b/server/etcdserver/apply/uber_applier.go @@ -115,6 +115,11 @@ func (a *uberApplier) Apply(r *pb.InternalRaftRequest) *Result { // then dispatch() unpacks the request to a specific method (like Put), // that gets executed down the hierarchy again: // i.e. CorruptApplier.Put(CappedApplier.Put(...(BackendApplier.Put(...)))). + // + // CAUTION: The context below should NOT be changed to a bounded value without + // first addressing the risk of a transaction's operations being only partially + // applied when some operations timeout. More details here: + // https://github.com/etcd-io/etcd/issues/18667#issuecomment-2392286839 return a.applyV3.Apply(context.TODO(), r, a.dispatch) }