Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take lessons from #19179 to improve robustness test #19189

Open
serathius opened this issue Jan 14, 2025 · 2 comments
Open

Take lessons from #19179 to improve robustness test #19189

serathius opened this issue Jan 14, 2025 · 2 comments

Comments

@serathius
Copy link
Member

serathius commented Jan 14, 2025

What would you like to be added?

Creating separate issue to avoid mixing discussion on the #19179. In this issue let's discuss improvements to robustness tests.

Issue was only visible in regression tests only run in presubmits TestRobustnessRegression/Issue17780. During regular meeting we don't look at it at all. It only caught my during review.

This leaves a question: If exploratory tests are meant to be superset of regression test, why we don't see the issue there?

Looking for ideas how to improve situation.

Why is this needed?

It's worrying that it took us so long to discover issue very similar to #18089. Means we have much to improve coverage of interaction of compaction with watch.

@serathius
Copy link
Member Author

This might be a culprit

// For multiBatchCompaction we need to guarantee that there are enough revisions between two compaction requests.
// With addition of compaction requests to traffic this might be hard if experimental-compaction-batch-limit is too high.
if t.multiBatchCompaction {
return config.ServerConfig.ExperimentalCompactionBatchLimit <= 10
}

@serathius
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant