From d7c65f9d6bcef71dd5b7138219e7e3dedb6f9073 Mon Sep 17 00:00:00 2001 From: Ishan Tyagi Date: Thu, 19 Dec 2024 13:53:20 +0530 Subject: [PATCH] Addressed the review comments. Signed-off-by: ishan16696 --- server/embed/config_test.go | 6 +++--- server/features/etcd_features.go | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/server/embed/config_test.go b/server/embed/config_test.go index e68f73310b7c..9a24e5eb9032 100644 --- a/server/embed/config_test.go +++ b/server/embed/config_test.go @@ -109,7 +109,7 @@ func TestConfigFileFeatureGates(t *testing.T) { features.DistributedTracing: false, features.StopGRPCServiceOnDefrag: false, features.InitialCorruptCheck: false, - features.TxnModeWriteWithSharedBuffer: false, + features.TxnModeWriteWithSharedBuffer: true, }, }, { @@ -159,7 +159,7 @@ func TestConfigFileFeatureGates(t *testing.T) { features.StopGRPCServiceOnDefrag: true, features.DistributedTracing: false, features.InitialCorruptCheck: false, - features.TxnModeWriteWithSharedBuffer: false, + features.TxnModeWriteWithSharedBuffer: true, }, }, { @@ -169,7 +169,7 @@ func TestConfigFileFeatureGates(t *testing.T) { features.StopGRPCServiceOnDefrag: false, features.DistributedTracing: false, features.InitialCorruptCheck: false, - features.TxnModeWriteWithSharedBuffer: false, + features.TxnModeWriteWithSharedBuffer: true, }, }, { diff --git a/server/features/etcd_features.go b/server/features/etcd_features.go index 591ba37e601b..2e7ebd569578 100644 --- a/server/features/etcd_features.go +++ b/server/features/etcd_features.go @@ -68,7 +68,7 @@ var ( StopGRPCServiceOnDefrag: {Default: false, PreRelease: featuregate.Alpha}, InitialCorruptCheck: {Default: false, PreRelease: featuregate.Alpha}, CompactHashCheck: {Default: false, PreRelease: featuregate.Alpha}, - TxnModeWriteWithSharedBuffer: {Default: false, PreRelease: featuregate.Alpha}, + TxnModeWriteWithSharedBuffer: {Default: true, PreRelease: featuregate.Beta}, } // ExperimentalFlagToFeatureMap is the map from the cmd line flags of experimental features // to their corresponding feature gates.