Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sound output class instead of i2s #7

Open
badgeek opened this issue Nov 16, 2018 · 3 comments
Open

sound output class instead of i2s #7

badgeek opened this issue Nov 16, 2018 · 3 comments

Comments

@badgeek
Copy link
Contributor

badgeek commented Nov 16, 2018

what do you think? @ChrisMicro

class SoundOutput

@ChrisMicro
Copy link
Contributor

The main reason why I made the I2S class is to be compatible with the Arduino I2S definition:
https://www.arduino.cc/en/Reference/I2S

The advantage it the compatibility with the STM32GENERIC implementation here
https://github.com/ChrisMicro/STM32GENERIC/tree/master/STM32/libraries/I2S

With this the software can easily ported between this two MCU architectures.

Also Adafruit has adopted the API:
https://github.com/adafruit/Adafruit_ZeroI2S

The higher level functions should be in a separate class like described in the Arduino Sound Library:
https://www.arduino.cc/en/Reference/ArduinoSound

@badgeek
Copy link
Contributor Author

badgeek commented Nov 16, 2018

have you test this on stm32 blue pill? how does it sound ? with or without dac?

@ChrisMicro
Copy link
Contributor

Not with the BluePill. I used the STM32F407 Discovery
https://github.com/ChrisMicro/Arduino_STM32F4_Discovery

and the cheaper STM32F411 Discovery

and the STM32F407 Black:
https://wiki.stm32duino.com/index.php?title=STM32F407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants