Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for ignoring sync methods from certain locations #392

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: add support for ignoring sync methods from certain locations #392

wants to merge 2 commits into from

Conversation

RebeccaStevens
Copy link

Fixes #391

Adds the ability to ignore entire packages, or just a subset of functions from them along with other things.
This also resolves the issue of name clashes.

Example:

/* eslint n/no-sync: ["error", { ignores: [{ from: 'package', package: 'effect' }]}] */

import { Effect } from "effect"
const value = Effect.runSync(Effect.succeed(42))

This follows ts eslint's TypeOrValueSpecifier.

@RebeccaStevens RebeccaStevens force-pushed the expand-ignore branch 3 times, most recently from d27b2a8 to c399441 Compare November 28, 2024 11:57
@aladdin-add aladdin-add self-requested a review November 29, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aladdin-add aladdin-add Awaiting requested review from aladdin-add

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dependencies enhancement rule:update An update to a current rule typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Expand no-sync's ignores option
2 participants
@RebeccaStevens @scagood