Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore Generics for Accenti / Casei #65

Open
eseglem opened this issue Jan 12, 2024 · 0 comments
Open

Explore Generics for Accenti / Casei #65

eseglem opened this issue Jan 12, 2024 · 0 comments

Comments

@eseglem
Copy link
Owner

eseglem commented Jan 12, 2024

Currently Accenti and Casei are a bit tricky, where each one has subclasses for CharacterExpression and PatternExpression

  • Accenti
    • AccentiCharacterExpression
    • AccentiPatternExpression
  • Casei
    • CaseiCharacterExpression
    • CaseiPatternExpression

This allows the proper enforcement of types, but generics could be nice to have. The issue is with Pydantic and runtime typing not completely lining up. A lot of messy attempts have been made to get it working but still trying to find a good solution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eseglem