Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Screen] Conversation Composer #1498

Open
7 tasks done
nplasterer opened this issue Jan 10, 2025 · 9 comments · Fixed by #1513
Open
7 tasks done

[Screen] Conversation Composer #1498

nplasterer opened this issue Jan 10, 2025 · 9 comments · Fixed by #1513
Assignees
Labels

Comments

@nplasterer
Copy link
Collaborator

nplasterer commented Jan 10, 2025

On click of the new conversation button
Screenshot 2025-01-09 at 7 35 57 PM

Take you to a composer to create a new conversations
https://www.figma.com/design/p6mt4tEDltI4mypD3TIgUk/Converse-App?node-id=5026-27441&t=Tso4OHIbfHTlG5bz-0

Screenshot 2025-01-09 at 7 41 08 PM

users list designs: https://www.figma.com/design/p6mt4tEDltI4mypD3TIgUk/Converse-App?node-id=5191-4200&t=KDRZMuK1xpiNBKG9-11

  • Ability to type in user names and select them from a menu to add them to a conversation
  • Ability to type in a wallet address to the list (if the user does not have a convos identity)
    • Check to see if this wallet address is on the V3 network or not and show an error otherwise
  • Show new group in the top right corner if more than 1 identity is pre-populated if only one identity show new convo
  • If the address is only 1 person and a message is typed and sent and a dm already exists with that user drop on the existing dm screen and send the message
  • If the address is only 1 person create a dm and send the message
  • If multiple addresses are used create a group chat and send the message
@nplasterer
Copy link
Collaborator Author

nplasterer commented Jan 10, 2025

@covrter can you give me a few visuals:

  • What it would look like to start typing a name and how the pop up to select a name would look?
  • What it would look like if I have a wallet address mixed in with the convos identities?

CleanShot 2025-01-13 at 13 26 17@2x

Updated 1/16 — here's the wallet address chip mixed in!

  • chip text is 0x1a2b…9999 (not that there is an elipsis character to use which is tidier than using 3 periods)
  • chip pfp gets the "default" avatar using the first 2 digits beyond the 0x — so in this case it's 1a

Image

@nplasterer
Copy link
Collaborator Author

Replaces
Image

@technoplato
Copy link
Collaborator

@nplasterer are we okay to consider sender-switching out of scope for this ticket?

CleanShot 2025-01-10 at 11 12 00@2x

@nplasterer
Copy link
Collaborator Author

Yes that is out of scope.

@nplasterer
Copy link
Collaborator Author

nplasterer commented Jan 16, 2025

Compiling a first pass bug list

Must

  • group creation errors are not surfaced it just looks like nothing happened when creation fails (adding self to group, bad keypackage etc..)
  • Identity look up should also match on name (sorry I was getting confused between username and display name - fixed by https://github.com/ephemeraHQ/converse-backend/pull/85)
  • The name look up should be inline with the selected names per designs
    • add “To” before the input field for clarity that you’re picking recipients (should be )
    • tapping a person chip shouldn’t delete it — it should select it; and then with keyboard “delete” key you can delete it or type over it (see iMessage and Messenger )
    • do not need a “clear” button in right of input field (bc it will now hold the chips too)
    • keep input focused even after I add a recipient (so keyboard stays up and I can quickly add more ppl) …
    • only time keyboard should be hidden on this view is when scrolling a long list of search results (I think)
  • add “no results” state for user search with share sheet tap — Loom, Figma
  • use new header UI style (taller, header on left, etc.)
  • remove “New convo” / “New group” in top right corner (it’s not useful unless it’s an entrypoint to setting group info priorto invitations, which we can treat as an incremental "new feature" for later)

Should

  • Should be an indicator that it's looking for names. When I type in Naomi and nothing happens its confusing. If no names are found it should indicate that after a timeout.

  • I can't send an image as a first message

  • include pfp in person chip

  • pasting a valid ethereum address that corresponds to an existing xmtp should immediately add that user to the pending group members chips after resolving the appropriate display value for the user

    • ie : username, display name, .eth address according to existing business logic and falling back to 0x... in the case that they have not created converse credentials yet
    • 0x only chips should remove 0x prefix and display first two hex values after the prefix in the avatar
  • pasting a 0x address that is on xmtp, but does not have any converse metadata (username, display name, etc) doesn't turn into a chip, it just sits in the input as text

  • allow space character in recipient search to enable finding people with spaces in display name (e.g. Billie Bob, Tiger Woods)

  • I compose a new message to a person who I’d “deleted” but not blocked. Composer opens the convo but my new message isn’t in the chat (but old one is) and convo isn’t added back to the conversations list (but should be)

  • Should immediately drop on screen with message and handle conversation lookup or creation and message send in background

  • A weird animation when entering the composer the keyboard is already open but the input field rises from the bottom independently (@thierryskoda on a fix for this)

@technoplato
Copy link
Collaborator

technoplato commented Jan 16, 2025

Compiling a first pass bug list

Must

  • group creation errors are not surfaced it just looks like nothing happened when creation fails (adding self to group, bad keypackage etc..)[x] Identity look up should also match on name

Should

  • Should be an indicator that it's looking for names. When I type in Naomi and nothing happens its confusing. If no names are found it should indicate that after a timeout.[ ] Should immediately drop on screen with message and handle conversation lookup or creation and message send in background[ ] The name look up should be inline with the selected names per designs[ ] A weird animation when entering the composer the keyboard is already open but the input field rises from the bottom independently[ ] I can't send an image as a first message

@nplasterer here's a loom addressing these: https://www.loom.com/share/0bea570bc1694c3ab6f2d3c1a6f47440 and the pr: https://github.com/ephemeraHQ/converse-app/pull/1532/files

@technoplato
Copy link
Collaborator

@technoplato
Copy link
Collaborator

spaces and username search working:

Image***

@technoplato
Copy link
Collaborator

@covrter type over it (see iMessage and Messenger is just a teeny complicated because to simplify this component the input box is always at the end. Is that groovy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants