Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why were the cosmology test problems removed? #187

Open
charmoniumQ opened this issue Apr 20, 2022 · 1 comment
Open

Why were the cosmology test problems removed? #187

charmoniumQ opened this issue Apr 20, 2022 · 1 comment

Comments

@charmoniumQ
Copy link

charmoniumQ commented Apr 20, 2022

Hello,

Why was run/CosmologySimulation/AMRCosmology/AMRCosmology.enzo removed in df2a002020d43c30ea660766c5cbbea447a7bcdd (tagging @kohdaegene)?

This is still referenced in the documentation doc/manual/source/supplementary_info/TestProblems.rst.

I'm asking because the documentation for MUSIC (page 14) says to use that as a guide for designing new cosmological input parameters, which what I want to do. I'm wondering if they still serve as a good example. If not, what should I use as an example for cosmological simulation?

@gregbryan
Copy link
Contributor

That was removed because it was actually built around the old initial condition generator that came with enzo; we have since moved to using MUSIC as the primary generator and this is demonstrated with the test problem in the run/CosmologySimulation/amr_cosmology directory. I think that will serve as useful example to how to use MUSIC -- there are some notes there (also see https://enzo.readthedocs.io/en/latest/user_guide/CosmologicalInitialConditions.html).

Thanks for pointing out both that the documentation in that table still refers to that problem -- it would be great if you could submit a PR to update that! (And also submit a fix to the MUSIC maintainers to update their enzo-related documentation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants