Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thoughts on the "Interface" suffix #4

Closed
florimondmanca opened this issue Jan 30, 2020 · 3 comments
Closed

Thoughts on the "Interface" suffix #4

florimondmanca opened this issue Jan 30, 2020 · 3 comments

Comments

@florimondmanca
Copy link
Member

Currently we have here:

  • AsyncDispatchInterface
  • SyncDispatchInterface

The Interface suffix looks a bit jarring to me, as in "of course they are interfaces, aren't they?".

What was the motivation for departing from AsyncDispatcher/SyncDispatcher?
@florimondmanca florimondmanca changed the title Thoughts on dropping the "Interface" suffix? Thoughts on the "Interface" suffix Jan 30, 2020
@florimondmanca
Copy link
Member Author

Other potential naming, inspired by python-trio/hip#124 (comment), would be that of "transports", e.g...

  • AsyncHTTPTransport
  • SyncHTTPTransport

@kousikmitra
Copy link

@florimondmanca What about these?

  • AsyncHTTPConnection
  • SyncHTTPConnection

@tomchristie
Copy link
Member

Rolling with AsyncHTTPTransport/SyncHTTPTransport at the moment. Open to design discussions continuing on this, but that feels right for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tomchristie @kousikmitra @florimondmanca