Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for FontAwesome 5 #14

Open
jcf opened this issue Jan 26, 2018 · 3 comments
Open

Support for FontAwesome 5 #14

jcf opened this issue Jan 26, 2018 · 3 comments

Comments

@jcf
Copy link

jcf commented Jan 26, 2018

It looks like the latest version of FontAwesome has changed a load of their UTF codes.

The new codes are conveniently enumerated in this YAML file so the Ruby script that generates the data file could be easily modified to work with FA 5 if that's something you're interested in.

Have you thought about which versions to support and how to go about it?
@gongzhitaao
Copy link

@jcf I think it might be easy to upgrade. Just generate your own fontawesome-alist defined in fontawesome-data.el, the code in fontawesome.el need not be changed.

@jcf
Copy link
Author

jcf commented Apr 24, 2018

@gongzhitaao it would be easy, but this is @syohex's project and I'm not going to make a large change to it without a 👍 beforehand.

@jcs090218
Copy link
Collaborator

@jcf If you wish, you can make a PR! Then I will review it! Thanks! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jcf @gongzhitaao @jcs090218