Dialog Discussion #592
Replies: 12 comments
-
Ideas for dark suggested action buttons: |
Beta Was this translation helpful? Give feedback.
-
@micahilbery It looks like the darkest accent color for suggested actions is darker than the normal button here, which almost makes the suggested button look like it's insensitive. I wonder if we can tint the normal button color toward the accent color for suggested actions, and if that would mean we'd need to either still use white text for contrast, or mix the accent text color with white to lighten it up? |
Beta Was this translation helpful? Give feedback.
-
Yeah I haven’t color checked those, but I agree they look low contrast and much darker than the regular button color. Maybe we could consider a different approach for destructive actions altogether like a regular button with a red border or with a warning icon or some kind of other distinctive marker |
Beta Was this translation helpful? Give feedback.
-
Maybe we could always pair a destructive action dialog with a warning icon, and never use a warning icon on a dialog that isn't leading to some destructive action, that way we could keep the soft red on a red accent system, because people would then get used to seeing warning paired with destructive actions. |
Beta Was this translation helpful? Give feedback.
-
@cassidyjames Here's it using the mix of the base color and the accent color for the background and a mix of the accent color and white for the text: |
Beta Was this translation helpful? Give feedback.
-
Is it just me or does anybody else get bugged by that text alignment? Maybe something more like this? |
Beta Was this translation helpful? Give feedback.
-
@jtrees this is unfortunately not possible because of the way the widgets are constructed. I've filed this issue to at least try to align checkbuttons and expanders. But, in Gtk this is actually a single widget that includes the checkbox itself and its label. So the best we can do is: |
Beta Was this translation helpful? Give feedback.
-
@danrabbit Huh, that's a shame. |
Beta Was this translation helpful? Give feedback.
-
@danrabbit Would it be possible to have a more prominent outline and sheen to the buttons? They look a little too soft compared to the more flat and contrasty style of the popup panel. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
I really like the one with white text labels on the original post by Daniel. Material design achieves a nice balance with this by setting in-box text levels at 85-90% opacity. You still get high contrast while not looking completely out of place. |
Beta Was this translation helpful? Give feedback.
-
@CainCosta Totally agree that the white text looks great, and it's akin to the already existing buttons too. I think the reason Daniel only gave the destructive buttons white text is so they can be distinguished from the user accented ones. |
Beta Was this translation helpful? Give feedback.
-
Exploring some dialog design stuff for Greenfield.
A huge consideration with Greenfield is contrast. So you'll notice that buttons stand out a lot more here. Overall, superfluous details are made much more subtle, but I don't feel like overall things are "flatter". I think we're using depth a lot more here actually.
Here's a comparison:
BEFORE
AFTER
ACCENT COLORS
One of the considerations we're working with is customizable accent colors. This is something that developers can set to reinforce their own branding, but we also want users to be able to set their own default accent color. The idea here is that offering some customization options can satisfy the need that drives user to change their stylesheet, but in a way that doesn't lead to application breakage.
You'll notice the following screenshots don't have a shadow in that action box. That's just because I did this before messing with that style. Consider these all just sketches. I haven't checked anything for contrast and everything is subject to change.
This obviously leaves us in a place where we need to differentiate between red accent color and destructive action. Using a lighter button style leans well into this:
But it brings up questions about if this works as well in the dark style:
I made this branch: elementary/granite#374
And here's the CSS I've been playing with in Inspector:
Beta Was this translation helpful? Give feedback.
All reactions