Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Granite.ButtonBox? #577

Open
danirabbit opened this issue Jan 24, 2022 · 2 comments
Open

Granite.ButtonBox? #577

danirabbit opened this issue Jan 24, 2022 · 2 comments
Labels
Needs Design Waiting for input from the UX team

Comments

@danirabbit
Copy link
Member

Problem

We've lost Gtk.ButtonBox in GTK4 which provided us with some convenient properties.

Proposal

It might be worth seeing how many times we previously used ButtonBox and if it's worth providing either a Granite.ButtonBox widget or a buttonbox style class so we at least don't have to duplicate CSS for setting spacing between children

Prior Art (Optional)

No response
@danirabbit danirabbit added the Needs Design Waiting for input from the UX team label Jan 24, 2022
@danirabbit danirabbit moved this to Needs Discussion in GTK4 Porting Jan 24, 2022
@danirabbit danirabbit mentioned this issue Nov 17, 2022
Merged
@danirabbit
Copy link
Member Author

Noting that Gtk.ButtonBox also set a min-width of 86px for its children

@danirabbit
Copy link
Member Author

Just wanted to also note that ActionBar might be a better widget here than Box to use for this purpose with a button-box style since it has start, end, and center packing and we wouldn't need spacer widgets. Not sure if it's children are homogeneous so worth checking and comparing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Design Waiting for input from the UX team
Projects
GTK4 Porting
Status: Needs Discussion
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danirabbit