From ba4473af3e06d9202519df83ff0beb6dd2ebfbeb Mon Sep 17 00:00:00 2001 From: "electron-roller[bot]" <84116207+electron-roller[bot]@users.noreply.github.com> Date: Tue, 21 Nov 2023 18:52:14 +0000 Subject: [PATCH 1/2] chore: bump electronjs/node in .circleci/config.yml to 2.1.0 --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index db070ae..360b49c 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -2,7 +2,7 @@ version: 2.1 orbs: cfa: continuousauth/npm@2.1.0 - node: electronjs/node@1.4.1 + node: electronjs/node@2.1.0 workflows: test_and_release: From b70a3072b913fa402e26c9ebd6a544eb02009a1e Mon Sep 17 00:00:00 2001 From: George Xu Date: Tue, 21 Nov 2023 17:20:43 -0800 Subject: [PATCH 2/2] build: add install-rosetta step --- .circleci/config.yml | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 360b49c..7e58cdc 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -10,6 +10,14 @@ workflows: jobs: - node/test: name: test-<< matrix.executor >>-<< matrix.node-version >> + pre-steps: + - when: + condition: + and: + - equal: [ node/macos, << matrix.executor >> ] + - equal: [ '14.16', << matrix.node-version >> ] + steps: + - node/install-rosetta test-steps: - run: yarn prettier:check - run: yarn build @@ -23,10 +31,11 @@ workflows: - node/macos - node/windows node-version: - - '20.5' + - '20.9' - '18.17' - '16.20' - - '14.21' + # Stay below 14.17.0 or nvm tries to download arm64 artifacts which don't exist + - '14.16' - cfa/release: requires: - test