Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate kibana.index setting #82521

Closed
kobelb opened this issue Nov 3, 2020 · 7 comments · Fixed by #83988
Closed

Deprecate kibana.index setting #82521

kobelb opened this issue Nov 3, 2020 · 7 comments · Fixed by #83988
Labels
Project:RemoveLegacyMultitenancy Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@kobelb
Copy link
Contributor

kobelb commented Nov 3, 2020

As part of the effort to remove legacy multi-tenancy, we should deprecate the kibana.index setting.
@kobelb kobelb added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Project:RemoveLegacyMultitenancy labels Nov 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@kobelb kobelb mentioned this issue Nov 3, 2020
Closed
14 tasks
@pgayvallet
Copy link
Contributor

This specific issue is just about adding a deprecation warning on kibana.index in src/core/server/config/deprecation/core_deprecations.ts right? Do you have a specific deprecation message in mind?

"kibana.index" is deprecated and will no longer work after version 8.0. 
Using distinct spaces is now the recommended approach for multi-tenancy needs

Second question: Should we diverge between master and 7.x here: having master totally remove the property using unusedFromRoot and 7.x just logging the specific warning instead. Or should this be done at a later time?

@kobelb
Copy link
Contributor Author

kobelb commented Nov 4, 2020

This specific issue is just about adding a deprecation warning on kibana.index in src/core/server/config/deprecation/core_deprecations.ts right?
Yup!

Do you have a specific deprecation message in mind?

Great question. Ideally, we'd have some docs to point the user to. Lemme figure out where we should put these.

Second question: Should we diverge between master and 7.x here: having master totally remove the property using unusedFromRoot and 7.x just logging the specific warning instead. Or should this be done at a later time?

We definitely can. It will potentially make the testing/implementation of system-indices a bit more complicated, as we want to ensure this continues to work for the duration of 7.x even when the customer has set a custom kibana.index. We could also explore using version specific code-branching as well here.

@pgayvallet
Copy link
Contributor

We could also explore using version specific code-branching as well here

I have a lot to say on such option, but this probably requires an issue on its own, as it could/would be used on multiple features.

@joshdover
Copy link
Contributor

Earlier today we discussed getting this in sooner than later. If that's the route we want to take, we should make sure that whatever documentation we link to includes some information about how to migrate to Spaces and what upcoming work we are doing to make that easier (since many things are not supported right now).

@pgayvallet pgayvallet mentioned this issue Nov 20, 2020
Merged
@kobelb kobelb mentioned this issue Nov 20, 2020
Merged
@joshdover joshdover mentioned this issue Nov 25, 2020
Closed
33 tasks
@Desvelao Desvelao mentioned this issue Nov 7, 2022
Closed
8 tasks
fxprunayre added a commit to geonetwork/core-geonetwork that referenced this issue Jan 9, 2024
@fxprunayre
Kibana / Update install instruction
312b21e 
Related to elastic/kibana#82521.
fxprunayre added a commit to geonetwork/core-geonetwork that referenced this issue Feb 9, 2024
@josegar74 @fxprunayre
Elasticssearch 8 upgrade (#7599)
fbbefc2 
* Update to Elasticsearch 8. Use of Elasticsearch Java API Client instead of Java High Level REST Client

* Update to Elasticsearch 8 / WFS indexing draft. (#88)

* Update to Elasticsearch 8 / remove TODOs

* Update Elasticsearch client to version 8.11.3

* Elasticsearch / Update maven plugin.

* Associated record / Store all relations in index / Remove experimental feature, not used. Related to #4912

* Elasticsearch / Update maven plugin configuration. Avoid error like ERROR: Elasticsearch exited unexpectedly, with exit code 143

* Elasticsearch / Update MetadataUtils.getAssociated to retrieve scripted overview field

* Elasticsearch / Update MetadataUtils.getAssociated remove TODO comment

* Elasticsearch / Fix and refactor index readonly health check

* Elasticsearch / Log query error details

* Elasticsearch / Sonarlint improvements

* Elasticsearch / WrapperQuery use base64 encoded JSON string query.

* Elasticsearch / Remove unused commented code from EsSearchManager

* Elasticsearch / More strict Xlink query based on UUID and fix check on hits. A request may return no hits but can be used to check number of hits. In such case we should avoid using hits.hits.size and use hits.total.value to get number of match.

* Elasticsearch / Health check / Fix number of hits info.

* Elasticsearch / Cleaning / No need to retrieve hits to only get matches.

* Elasticsearch / Deprecated field [include] used, expected [includes] instead.

* Elasticsearch / Remove 'Clear XLink cache' from Administration > Tools, clear the Xlink cache automatically before indexing and remove non-implemented code to retrieve metadata with XLink (not required anymore)

* Kibana / Update install instruction

Related to elastic/kibana#82521.

* Elasticsearch / Remove unused imports

* Kibana / Update default dashboards.

* Elasticsearch / Documentation / Update Elasticsearch version

* Elasticsearch / Fix logger module name typo

---------

Co-authored-by: François Prunayre <[email protected]>
@haodketernal
Copy link

I have custom kibana system index like ".abc-kibana"

what should I do when upgrade from 7.17 to 8.14 ?

Is kibana 8 automatically detect old index to migrate ??

@lukeelmers
Copy link
Member

@haodketernal This scenario was not documented as well as it should have been, however there is an open issue with some proposed steps for ensuring migrations still run as expected... I'd recommend following along and commenting there: #152792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Project:RemoveLegacyMultitenancy Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate kibana.index setting kobelb/kibana
6 participants
@kobelb @pgayvallet @lukeelmers @joshdover @elasticmachine @haodketernal