-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ResponseOps][Rules] Use rule form instead of rule flyout in observability solution #206774
base: main
Are you sure you want to change the base?
Conversation
Pinging @elastic/response-ops (Team:ResponseOps) |
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Thanks for making this change 🙏🏻 I haven't finished the review, just an early feedback: |
Fixed both issues in 134313d breadcrumb_obs.mov |
@@ -53,7 +55,7 @@ export const getInitialMultiConsumer = ({ | |||
} | |||
|
|||
// If o11y is in the valid consumers, just use that | |||
if (validConsumers.includes(AlertConsumers.OBSERVABILITY)) { | |||
if (isServerless && validConsumers.includes(AlertConsumers.OBSERVABILITY)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because validConsumers
of o11y solution always has AlertConsumers.OBSERVABILITY
, however we don't want it for some rules like (custom threshold, esql etc.) which have other consumers like logs, metrics etc.
However if it is serverless, we want all rules to have AlertConsumers.OBSERVABILITY
consumer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to add the decision here: (based on discussion with @maciejforcone)
We decided to only have the rule form in the rule creation flow on the rules page. We will keep the flyout for other scenarios (i.e., edit and rule creation on the app pages.)
@maryam-saeidi that sounds logical, but i think we should make those flyouts at least resizeable, i think the actual place like expression and graphs on the flyout is usually very congested, either we can increase the size or make the fields above expression compressed to give maximum space to the content which matters on flyouts. I think purpose of this initiative was to address these things but if we still kept those as flyouts, it kinda defeats the purpose. |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsasync chunk count
miscellaneous assets size
History
|
Good point. The plan is to have the option to resize the flyout but in a different step. @cnasikas shared that this option will be easier to add when @Zacqary 's work on the rule form is finished (I believe it is related to this PR) |
Summary
Resolves #195574
This PR updates observability solution to use new rule form to
create
andedit
rules same asstack management > rules
page.It removes usage of rule flyout form o11y solution. Also updated functional tests.
Checklist
How to test
Release Note
Use rule form to create or edit rules in observability.