Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] [Reporting] Chrome no longer hidden for reports #205794

Open
Heenawter opened this issue Jan 7, 2025 · 2 comments
Open

[Dashboard] [Reporting] Chrome no longer hidden for reports #205794

Heenawter opened this issue Jan 7, 2025 · 2 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Reporting:Screenshot Reporting issues pertaining to PNG/PDF file export impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@Heenawter
Copy link
Contributor

Heenawter commented Jan 7, 2025

Describe the bug:

When generating Dashboard reports in versions >= 8.16.0, the Kibana chrome is not hidden as it should be.

Steps to reproduce:

  1. Open a sample Dashboard
  2. Generate a print-optimized PDF report or add &_a=(viewMode:'print') to the end of you URL to simulate the print layout
  3. Notice that the chrome shows up 🔥

Current behaviour:

ReportGeneratedOnMain.pdf:

Image

ReportGeneratedOnV8.16.2.pdf:

Image

Expected behaviour:

ReportGeneratedOnV8.15.5.pdf:

Image
@Heenawter Heenawter added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Reporting:Screenshot Reporting issues pertaining to PNG/PDF file export impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Jan 7, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@Heenawter
Copy link
Contributor Author

Heenawter commented Jan 7, 2025

This is an unintended consequence of this PR - specifically, the removal of the useEffect in src/plugins/dashboard/public/dashboard_top_nav/internal_dashboard_top_nav.tsx. Unfortunately, it is not as simple as simply adding this useEffect back because it was removed to fix a bug with fullscreen mode.

That being said, we could toggle the chrome visibility by subscribing to the viewMode publishing subject instead, perhaps? cc @nreese just in case this would have unintended consequences 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Reporting:Screenshot Reporting issues pertaining to PNG/PDF file export impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

2 participants