-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search][Stack] Web Crawlers coming soon pages #205718
[Search][Stack] Web Crawlers coming soon pages #205718
Conversation
|
||
import { COMING_SOON_LABEL } from '../../../shared/constants'; | ||
import { GithubIcon } from '../../../shared/icons/github_icon'; | ||
import CrawlerIcon from '../../../shared/icons/web_crawlers.svg'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consuming crawler.tsx
as exported SVG object didn't let scale the icon. Importing a SVG as we do in Serverless does.
TODO: We should move the Web Crawler icon and Connector icon to the EUI repo to let reuse it and make it ready to be rendered properly either dark or light mode. Right now both are only suitable for default light mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's move the crawler repo link into a global constant in a followup PR
data-test-subj="entSearchContentConnectorsLearnMoreLink" | ||
external | ||
target="_blank" | ||
href={'https://github.com/elastic/crawler'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link should be a constant as well, it's hardcoded in multiple places already https://github.com/search?q=repo%3Aelastic%2Fkibana%20https%3A%2F%2Fgithub.com%2Felastic%2Fcrawler&type=code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps @leemthompo has already an approach on how to manage these external links. Maybe consuming the docLinks
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoseLuisGJ I pinged you in Slack with link to doclink creation info/ examples
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
cc @JoseLuisGJ |
<p> | ||
<FormattedMessage | ||
id="xpack.enterpriseSearch.webcrawlers.headerContent" | ||
defaultMessage="Discover extract and index searchable content from websites and knowledge bases {learnMoreLink}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoseLuisGJ Just a punctuation edit if you're touching this copy again soon:
"Discover, extract, and index searchable content from websites and knowledge bases."
## Summary This PR shows the `SearchEmptyPrompts` for the Web Crawlers section in Stack in Stack 9.0 as we do in ES3 due to Web Crawlers will not be available as Elastic Managed since this version. We are also leveraging as shared code as possible consuming the `@kbn/search-shared-ui` content. ![CleanShot 2025-01-07 at 12 08 36@2x](https://github.com/user-attachments/assets/6483fa0b-21ee-40fa-b749-3a04e0732c92) ![CleanShot 2025-01-07 at 12 09 00@2x](https://github.com/user-attachments/assets/91f3bf8f-6b33-4e7f-9e24-b7844bb60768)
Summary
This PR shows the
SearchEmptyPrompts
for the Web Crawlers section in Stack in Stack 9.0 as we do in ES3 due to Web Crawlers will not be available as Elastic Managed since this version. We are also leveraging as shared code as possible consuming the@kbn/search-shared-ui
content.