Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search][Stack] Web Crawlers coming soon pages #205718

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

JoseLuisGJ
Copy link
Contributor

@JoseLuisGJ JoseLuisGJ commented Jan 7, 2025

Summary

This PR shows the SearchEmptyPrompts for the Web Crawlers section in Stack in Stack 9.0 as we do in ES3 due to Web Crawlers will not be available as Elastic Managed since this version. We are also leveraging as shared code as possible consuming the @kbn/search-shared-ui content.

CleanShot 2025-01-07 at 12 08 36@2x

CleanShot 2025-01-07 at 12 09 00@2x

@JoseLuisGJ JoseLuisGJ changed the title Initial commit [Search][Stack] Web Crawlers coming soon pages Jan 7, 2025
@JoseLuisGJ JoseLuisGJ self-assigned this Jan 7, 2025
@JoseLuisGJ JoseLuisGJ added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v9.0.0 Team:Search labels Jan 7, 2025
@JoseLuisGJ JoseLuisGJ marked this pull request as ready for review January 7, 2025 12:30
@JoseLuisGJ JoseLuisGJ requested a review from a team as a code owner January 7, 2025 12:30

import { COMING_SOON_LABEL } from '../../../shared/constants';
import { GithubIcon } from '../../../shared/icons/github_icon';
import CrawlerIcon from '../../../shared/icons/web_crawlers.svg';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consuming crawler.tsx as exported SVG object didn't let scale the icon. Importing a SVG as we do in Serverless does.
TODO: We should move the Web Crawler icon and Connector icon to the EUI repo to let reuse it and make it ready to be rendered properly either dark or light mode. Right now both are only suitable for default light mode.

Copy link
Member

@jedrazb jedrazb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's move the crawler repo link into a global constant in a followup PR

data-test-subj="entSearchContentConnectorsLearnMoreLink"
external
target="_blank"
href={'https://github.com/elastic/crawler'}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link should be a constant as well, it's hardcoded in multiple places already https://github.com/search?q=repo%3Aelastic%2Fkibana%20https%3A%2F%2Fgithub.com%2Felastic%2Fcrawler&type=code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps @leemthompo has already an approach on how to manage these external links. Maybe consuming the docLinks?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoseLuisGJ I pinged you in Slack with link to doclink creation info/ examples

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 2290 2300 +10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB +8.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
enterpriseSearch 52.5KB 52.6KB +59.0B

History

cc @JoseLuisGJ

@delanni delanni merged commit 60f5b1d into elastic:main Jan 8, 2025
7 of 8 checks passed
<p>
<FormattedMessage
id="xpack.enterpriseSearch.webcrawlers.headerContent"
defaultMessage="Discover extract and index searchable content from websites and knowledge bases {learnMoreLink}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoseLuisGJ Just a punctuation edit if you're touching this copy again soon:

"Discover, extract, and index searchable content from websites and knowledge bases."

crespocarlos pushed a commit to crespocarlos/kibana that referenced this pull request Jan 8, 2025
## Summary

This PR shows the `SearchEmptyPrompts` for the Web Crawlers section in
Stack in Stack 9.0 as we do in ES3 due to Web Crawlers will not be
available as Elastic Managed since this version. We are also leveraging
as shared code as possible consuming the `@kbn/search-shared-ui`
content.

![CleanShot 2025-01-07 at 12 08
36@2x](https://github.com/user-attachments/assets/6483fa0b-21ee-40fa-b749-3a04e0732c92)

![CleanShot 2025-01-07 at 12 09
00@2x](https://github.com/user-attachments/assets/91f3bf8f-6b33-4e7f-9e24-b7844bb60768)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Search v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants