Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance] Report scale dimensions for service-map and hosts #205607

Merged
merged 9 commits into from
Jan 8, 2025

Conversation

kpatticha
Copy link
Contributor

@kpatticha kpatticha commented Jan 6, 2025

closes https://github.com/elastic/observability-dev/issues/3777

Summary

This PR provides scale dimensions for the service map and infra host pages without introducing any additional requests.

Global Service Map and Per-service APM Service Map

Metric Description
num_of_nodes Total number of discovered nodes (services + dependenies
num_of_traces Total number of traces

Infra

Metric Description default
num_of_hosts Total number of hosts
max_hosts_per_page Maximum number of host returne 50/100/500 100
Page Screenshot
Global Service Map Screenshot 2025-01-08 at 12 54 43
Per-service APM Service Map Screenshot 2025-01-08 at 12 53 07
Infra !Screenshot 2025-01-08 at 12 56 00

How to test

  • Open any of the above pages
  • In the network tab, look for kibana:plugin_render_time

@kpatticha kpatticha requested review from a team as code owners January 6, 2025 13:37
@botelastic botelastic bot added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Jan 6, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@kpatticha kpatticha added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Jan 6, 2025
@kpatticha kpatticha requested a review from crespocarlos January 7, 2025 11:53
@jennypavlova jennypavlova self-requested a review January 7, 2025 12:34
Copy link
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I have one question about the services count: I see in the service map different numbers in the count (it's services + dependency) :
image

The trace count is different compared to the traces page (23 traces are shown on the service map tracking and only 13 traces are shown on the traces page) :

image

Maybe there are some filters or other logic I am not aware of but decided to share that anyway to make sure I understand how we track it 😅 (and make sure that it's not an issue)

@elasticmachine
Copy link
Contributor

💔 Build Failed

Failed CI Steps

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [e04b200]

History

@kpatticha
Copy link
Contributor Author

kpatticha commented Jan 8, 2025

LGTM I have one question about the services count: I see in the service map different numbers in the count (it's services + dependency) :

Good catch, thanks for checking. The count reflects the total number of nodes (services + dependencies) so the servicesCount field name is misleading. Renaming it to nodesCount / nodeCount would be more accurate as I believe it will be useful to have this dimension. wdyt?

The trace count is different compared to the traces page (23 traces are shown on the service map tracking and only 13 traces are shown on the traces page) :

Maybe there are some filters or other logic I am not aware of but decided to share that anyway to make sure I understand how we track it 😅 (and make sure that it's not an issue)

Yes, the top traces check if it's the root transaction so it's expected to be a lower nunber.

@jennypavlova
Copy link
Member

@kpatticha Thank you for explaining!

The count reflects the total number of nodes (services + dependencies) so the servicesCount field name is misleading. Renaming it to nodesCount / nodeCount would be more accurate as I believe it will be useful to have this dimension. wdyt?

I like your suggestion as node will be easier to understand in the context of a service map in this case (as you said we count both services + dependencies so I think nodeCount is good)

@kpatticha kpatticha enabled auto-merge (squash) January 8, 2025 10:58
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a logs-ux codeowner perspective

@kpatticha kpatticha merged commit 24f8888 into elastic:main Jan 8, 2025
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12672383328

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 205607

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants