[ES|QL] Add automated script to sync operators and add support for MATCH operators #205565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/kbn-esql-validation-autocomplete/src/definitions/types.ts
# Conflicts: # src/platform/packages/shared/kbn-esql-validation-autocomplete/src/definitions/generated/operators.ts
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
|
/ci |
|
/ci |
9 tasks
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
cc @qn895 |
stratoula
reviewed
Jan 8, 2025
| @@ -112,14 +112,17 @@ export function removeQuoteForSuggestedSources(suggestions: SuggestionRawDefinit | |||
| })); | |||
| } | |||
|
|
|||
| const leftHandSideParamName = new Set(['left', 'field', 'lhs']); | |||
There was a problem hiding this comment.
Haven't we mapped in the script above as left? Why do we need them here?
| @@ -117,56 +123,58 @@ export const isReturnType = (str: string | FunctionParameterType): str is Functi | |||
| str !== 'unsupported' && | |||
| (dataTypes.includes(str as SupportedDataType) || str === 'unknown' || str === 'any'); | |||
|
|
|||
| export interface Signature { | |||
| @@ -1060,7 +1068,7 @@ | |||
| { | |||
| "query": "row 1 years + 1 year", | |||
| "error": [ | |||
| "Argument of [+] must be [date], found value [1 years] type [duration]" | |||
| "Argument of [+] must be [date], found value [1 year] type [duration]" | |||
There was a problem hiding this comment.
So now we start the validation from the end and not from the beginning?
| extraSignatures?: Signature[]; | ||
| } | ||
| > = { | ||
| add: { |
There was a problem hiding this comment.
So every time a new operator is being added we need to add an entry here? Can this info be given by ES? Have we talked with them?
| @@ -384,7 +384,7 @@ export const comparisonFunctions: FunctionDefinition[] = [ | |||
| }, | |||
| ].map((op): FunctionDefinition => createComparisonDefinition(op)); | |||
|
|
|||
| const likeFunctions: FunctionDefinition[] = [ | |||
| const notLikeFunctions: FunctionDefinition[] = [ | |||
There was a problem hiding this comment.
I dont understand this change, the not_like is not being returned from ES?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds automated script to sync operators and add support for MATCH operators
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.