Preparation for High Contrast Mode, ML domain #205540
Open
+146
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
release_note:skip
18 tasks
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
botelastic
bot
added
the
Team:obs-ux-management
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History |
shahzad31
approved these changes
Jan 6, 2025
rmyz
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reviewers: Please test the code paths affected by this PR. See the "Risks" section below.
Part of work for enabling "high contrast mode" in Kibana. See #205411
Background:
Kibana will soon have a user profile setting to allow users to enable "high contrast mode." This setting will activate a flag with
<EuiProvider>that causes EUI components to render with higher contrast visual elements. Consumer plugins and packages need to be updated selected places where<EuiProvider>is wrapped, to pass theUserProfileServiceservice dependency from the CoreStart contract.NOTE: EUI currently does not yet support the high-contrast mode flag, but support for that is expected to come soon. These first PRs are simply preparing the code by wiring up the
UserProvideService.Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelinesRisks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.
UserProfileServicedependency comes from the CoreStart contract. If acquiring the service causes synchronous code to become asynchronous, check for race conditions or errors in rendering React components. Code owners for this PR need to manually test the affected code paths.