Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stack Monitoring] Turn off autoSortOptions for ilm.phase filter #205351

Merged
merged 2 commits into from
Jan 7, 2025
Merged

[Stack Monitoring] Turn off autoSortOptions for ilm.phase filter #205351

merged 2 commits into from
Jan 7, 2025

Conversation

kowalczyk-krzysztof
Copy link
Member

@kowalczyk-krzysztof kowalczyk-krzysztof commented Jan 2, 2025 •
edited by kibanamachine
Loading

Summary

This PR turns off auto sorting for ilm.phase filter, to keep the dropdown options in place as requested in #202596.
Closes: #202596

@kowalczyk-krzysztof kowalczyk-krzysztof added bug Fixes for quality problems that affect the customer experience Team:Monitoring Stack Monitoring team release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Jan 2, 2025
@kowalczyk-krzysztof kowalczyk-krzysztof self-assigned this Jan 2, 2025
@kowalczyk-krzysztof kowalczyk-krzysztof requested a review from a team as a code owner January 2, 2025 08:24
@kowalczyk-krzysztof kowalczyk-krzysztof added Feature:Stack Monitoring Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Jan 2, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@kowalczyk-krzysztof kowalczyk-krzysztof removed the Team:Monitoring Stack Monitoring team label Jan 2, 2025
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #3 / it should allow to update existing host with single host

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
indexLifecycleManagement 27.5KB 27.5KB +19.0B

History

cc @kowalczyk-krzysztof

ElenaStoeva
ElenaStoeva approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Changes lgtm, tested locally.

@kowalczyk-krzysztof kowalczyk-krzysztof merged commit 18fd171 into elastic:main Jan 7, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12650686858

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 7, 2025
@kowalczyk-krzysztof
[Stack Monitoring] Turn off autoSortOptions for ilm.phase filter (ela…
b2b4228 
…stic#205351)

## Summary

This PR turns off auto sorting for `ilm.phase` filter, to keep the
dropdown options in place as requested in elastic#202596.
Closes: elastic#202596

(cherry picked from commit 18fd171)
@kibanamachine kibanamachine mentioned this pull request Jan 7, 2025
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 7, 2025
@kibanamachine @kowalczyk-krzysztof
[8.x] [Stack Monitoring] Turn off autoSortOptions for ilm.phase filter (
d4eb8b4 
#205351) (#205710)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Stack Monitoring] Turn off autoSortOptions for ilm.phase filter
(#205351)](#205351)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Krzysztof
Kowalczyk","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-07T11:28:43Z","message":"[Stack
Monitoring] Turn off autoSortOptions for ilm.phase filter
(#205351)\n\n## Summary\r\n\r\nThis PR turns off auto sorting for
`ilm.phase` filter, to keep the\r\ndropdown options in place as
requested in #202596.\r\nCloses:
#202596","sha":"18fd1713b87319210b90f325d104593d5fcbcab9","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Kibana
Management","release_note:skip","Feature:Stack
Monitoring","v9.0.0","backport:prev-minor"],"title":"[Stack Monitoring]
Turn off autoSortOptions for ilm.phase
filter","number":205351,"url":"https://github.com/elastic/kibana/pull/205351","mergeCommit":{"message":"[Stack
Monitoring] Turn off autoSortOptions for ilm.phase filter
(#205351)\n\n## Summary\r\n\r\nThis PR turns off auto sorting for
`ilm.phase` filter, to keep the\r\ndropdown options in place as
requested in #202596.\r\nCloses:
#202596","sha":"18fd1713b87319210b90f325d104593d5fcbcab9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205351","number":205351,"mergeCommit":{"message":"[Stack
Monitoring] Turn off autoSortOptions for ilm.phase filter
(#205351)\n\n## Summary\r\n\r\nThis PR turns off auto sorting for
`ilm.phase` filter, to keep the\r\ndropdown options in place as
requested in #202596.\r\nCloses:
#202596","sha":"18fd1713b87319210b90f325d104593d5fcbcab9"}}]}]
BACKPORT-->

Co-authored-by: Krzysztof Kowalczyk <[email protected]>
kowalczyk-krzysztof added a commit to kowalczyk-krzysztof/kibana that referenced this pull request Jan 7, 2025
@kowalczyk-krzysztof
[Stack Monitoring] Turn off autoSortOptions for ilm.phase filter (ela…
ae7ee14 
…stic#205351)

## Summary

This PR turns off auto sorting for `ilm.phase` filter, to keep the
dropdown options in place as requested in elastic#202596.
Closes: elastic#202596
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
@kowalczyk-krzysztof @CAWilson94
[Stack Monitoring] Turn off autoSortOptions for ilm.phase filter (ela…
2aa7e0f 
…stic#205351)

## Summary

This PR turns off auto sorting for `ilm.phase` filter, to keep the
dropdown options in place as requested in elastic#202596.
Closes: elastic#202596
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElenaStoeva ElenaStoeva ElenaStoeva approved these changes

Assignees

@kowalczyk-krzysztof kowalczyk-krzysztof

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) bug Fixes for quality problems that affect the customer experience Feature:Stack Monitoring release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Stack Monitoring] Lifecycle phase dropdown re-orders options
4 participants
@kowalczyk-krzysztof @elasticmachine @kibanamachine @ElenaStoeva