-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Restore embeddable test coverage #204986
Open
dej611
wants to merge
18
commits into
elastic:main
Choose a base branch
from
dej611:fix/198754
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+887
−131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dej611
added
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
release_note:skip
Skip the PR/issue when compiling release notes
Feature:Lens
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
labels
Dec 19, 2024
dej611
commented
Dec 19, 2024
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
Dismissed the Data Discovery review because it looks like there are no longer changes in our area. |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
Feature:Lens
release_note:skip
Skip the PR/issue when compiling release notes
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #198754
Restore previous removed tests when performing the refactor.
The new tests take advantage of the new architecture to be more modular and close to the logic modules.
The
data_loader
tests are not just covering the re-render logic but also someexpression_params
logic, who in the past have proven to be the source of some bugs: specifically the tests will check that the params are correctly passed to the params logic and then stored correctly in the observable.New mocks take advantage of the plain initializers to build some of the API, that will make it in sync with the actual implementation for future maintenance.
Checklist
Check the PR satisfies following conditions.