Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Restore embeddable test coverage #204986

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Dec 19, 2024

Summary

Fixes #198754

Restore previous removed tests when performing the refactor.
The new tests take advantage of the new architecture to be more modular and close to the logic modules.

The data_loader tests are not just covering the re-render logic but also some expression_params logic, who in the past have proven to be the source of some bugs: specifically the tests will check that the params are correctly passed to the params logic and then stored correctly in the observable.

New mocks take advantage of the plain initializers to build some of the API, that will make it in sync with the actual implementation for future maintenance.

Checklist

Check the PR satisfies following conditions.

@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 19, 2024
@dej611 dej611 marked this pull request as ready for review December 19, 2024 17:29
@dej611 dej611 requested review from a team as code owners December 19, 2024 17:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@davismcphee davismcphee removed the request for review from a team January 3, 2025 19:30
@davismcphee
Copy link
Contributor

Dismissed the Data Discovery review because it looks like there are no longer changes in our area.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +79.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
lens 21 22 +1

Total ESLint disabled count

id before after diff
lens 21 22 +1

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens][Embeddable refactor] Write more tests for the new embeddable
6 participants