Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Remove unwanted console.log from pipeline.ts #204724

Merged
merged 5 commits into from
Jan 7, 2025
Merged

[CI] Remove unwanted console.log from pipeline.ts #204724

merged 5 commits into from
Jan 7, 2025

Conversation

delanni
Copy link
Contributor

@delanni delanni commented Dec 18, 2024 •
edited by kibanamachine
Loading

Summary

Logging to stdout from this file would result uploading the logged string to buildkite as a pipeline definition, causing errors (https://buildkite.com/elastic/kibana-pull-request/builds/261721#0193d94b-f05c-41d6-9865-3d3c331a6cc4)

Adds an inline eslint rule to warn about console.log/stdout usage, as this has happened before by oversight.

Overlaps with: #204672

@delanni delanni added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development labels Dec 18, 2024
@delanni delanni requested a review from a team as a code owner December 18, 2024 11:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@delanni delanni force-pushed the fix-ci-pipeline-renovate branch from 1491e98 to 1cb56fd Compare December 18, 2024 11:28
@delanni delanni force-pushed the fix-ci-pipeline-renovate branch from 1cb56fd to 961499a Compare December 18, 2024 11:31
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

The CI Stats report is too large to be displayed here, check out the CI build annotation for this information.

History

@delanni delanni requested a review from Ikuni17 January 6, 2025 14:41
@delanni delanni merged commit ae6d046 into main Jan 7, 2025
8 checks passed
@delanni delanni deleted the fix-ci-pipeline-renovate branch January 7, 2025 11:42
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12650888438

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 7, 2025
@delanni
[CI] Prevent console.log in pipeline.ts (elastic#204724)
81d56fe 
## Summary
~Logging to stdout from this file would result uploading the logged
string to buildkite as a pipeline definition, causing errors
(https://buildkite.com/elastic/kibana-pull-request/builds/261721#0193d94b-f05c-41d6-9865-3d3c331a6cc4)~

Adds an inline eslint rule to warn about `console.log/stdout` usage, as
this has happened before by oversight.

Overlaps with: elastic#204672

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit ae6d046)
@kibanamachine kibanamachine mentioned this pull request Jan 7, 2025
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 7, 2025
@delanni
[CI] Prevent console.log in pipeline.ts (elastic#204724)
cefe7ca 
## Summary
~Logging to stdout from this file would result uploading the logged
string to buildkite as a pipeline definition, causing errors
(https://buildkite.com/elastic/kibana-pull-request/builds/261721#0193d94b-f05c-41d6-9865-3d3c331a6cc4)~

Adds an inline eslint rule to warn about `console.log/stdout` usage, as
this has happened before by oversight.

Overlaps with: elastic#204672

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit ae6d046)
@kibanamachine kibanamachine mentioned this pull request Jan 7, 2025
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 7, 2025
@delanni
[CI] Prevent console.log in pipeline.ts (elastic#204724)
eb373cd 
## Summary
~Logging to stdout from this file would result uploading the logged
string to buildkite as a pipeline definition, causing errors
(https://buildkite.com/elastic/kibana-pull-request/builds/261721#0193d94b-f05c-41d6-9865-3d3c331a6cc4)~

Adds an inline eslint rule to warn about `console.log/stdout` usage, as
this has happened before by oversight.

Overlaps with: elastic#204672

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit ae6d046)
@kibanamachine kibanamachine mentioned this pull request Jan 7, 2025
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.16
✅ 8.17
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 7, 2025
@kibanamachine @delanni
[8.17] [CI] Prevent console.log in pipeline.ts (#204724) (#205713)
6f9ccb4 
# Backport

This will backport the following commits from `main` to `8.17`:
- [[CI] Prevent console.log in pipeline.ts
(#204724)](#204724)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alex
Szabo","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-07T11:42:45Z","message":"[CI]
Prevent console.log in pipeline.ts (#204724)\n\n## Summary\n~Logging to
stdout from this file would result uploading the logged\nstring to
buildkite as a pipeline definition, causing
errors\n(https://buildkite.com/elastic/kibana-pull-request/builds/261721#0193d94b-f05c-41d6-9865-3d3c331a6cc4)~\n\nAdds
an inline eslint rule to warn about `console.log/stdout` usage, as\nthis
has happened before by oversight.\n\nOverlaps with:
https://github.com/elastic/kibana/pull/204672\n\n---------\n\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"ae6d0463192501f4a81ffbe58a85e5c87d9aaca8","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","v9.0.0","backport:prev-major"],"title":"[CI]
Remove unwanted console.log from
pipeline.ts","number":204724,"url":"https://github.com/elastic/kibana/pull/204724","mergeCommit":{"message":"[CI]
Prevent console.log in pipeline.ts (#204724)\n\n## Summary\n~Logging to
stdout from this file would result uploading the logged\nstring to
buildkite as a pipeline definition, causing
errors\n(https://buildkite.com/elastic/kibana-pull-request/builds/261721#0193d94b-f05c-41d6-9865-3d3c331a6cc4)~\n\nAdds
an inline eslint rule to warn about `console.log/stdout` usage, as\nthis
has happened before by oversight.\n\nOverlaps with:
https://github.com/elastic/kibana/pull/204672\n\n---------\n\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"ae6d0463192501f4a81ffbe58a85e5c87d9aaca8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204724","number":204724,"mergeCommit":{"message":"[CI]
Prevent console.log in pipeline.ts (#204724)\n\n## Summary\n~Logging to
stdout from this file would result uploading the logged\nstring to
buildkite as a pipeline definition, causing
errors\n(https://buildkite.com/elastic/kibana-pull-request/builds/261721#0193d94b-f05c-41d6-9865-3d3c331a6cc4)~\n\nAdds
an inline eslint rule to warn about `console.log/stdout` usage, as\nthis
has happened before by oversight.\n\nOverlaps with:
https://github.com/elastic/kibana/pull/204672\n\n---------\n\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"ae6d0463192501f4a81ffbe58a85e5c87d9aaca8"}}]}]
BACKPORT-->

Co-authored-by: Alex Szabo <[email protected]>
kibanamachine added a commit that referenced this pull request Jan 7, 2025
@kibanamachine @delanni
[8.x] [CI] Prevent console.log in pipeline.ts (#204724) (#205714)
d103446 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[CI] Prevent console.log in pipeline.ts
(#204724)](#204724)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alex
Szabo","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-07T11:42:45Z","message":"[CI]
Prevent console.log in pipeline.ts (#204724)\n\n## Summary\n~Logging to
stdout from this file would result uploading the logged\nstring to
buildkite as a pipeline definition, causing
errors\n(https://buildkite.com/elastic/kibana-pull-request/builds/261721#0193d94b-f05c-41d6-9865-3d3c331a6cc4)~\n\nAdds
an inline eslint rule to warn about `console.log/stdout` usage, as\nthis
has happened before by oversight.\n\nOverlaps with:
https://github.com/elastic/kibana/pull/204672\n\n---------\n\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"ae6d0463192501f4a81ffbe58a85e5c87d9aaca8","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","v9.0.0","backport:prev-major"],"title":"[CI]
Remove unwanted console.log from
pipeline.ts","number":204724,"url":"https://github.com/elastic/kibana/pull/204724","mergeCommit":{"message":"[CI]
Prevent console.log in pipeline.ts (#204724)\n\n## Summary\n~Logging to
stdout from this file would result uploading the logged\nstring to
buildkite as a pipeline definition, causing
errors\n(https://buildkite.com/elastic/kibana-pull-request/builds/261721#0193d94b-f05c-41d6-9865-3d3c331a6cc4)~\n\nAdds
an inline eslint rule to warn about `console.log/stdout` usage, as\nthis
has happened before by oversight.\n\nOverlaps with:
https://github.com/elastic/kibana/pull/204672\n\n---------\n\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"ae6d0463192501f4a81ffbe58a85e5c87d9aaca8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204724","number":204724,"mergeCommit":{"message":"[CI]
Prevent console.log in pipeline.ts (#204724)\n\n## Summary\n~Logging to
stdout from this file would result uploading the logged\nstring to
buildkite as a pipeline definition, causing
errors\n(https://buildkite.com/elastic/kibana-pull-request/builds/261721#0193d94b-f05c-41d6-9865-3d3c331a6cc4)~\n\nAdds
an inline eslint rule to warn about `console.log/stdout` usage, as\nthis
has happened before by oversight.\n\nOverlaps with:
https://github.com/elastic/kibana/pull/204672\n\n---------\n\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"ae6d0463192501f4a81ffbe58a85e5c87d9aaca8"}}]}]
BACKPORT-->

Co-authored-by: Alex Szabo <[email protected]>
kibanamachine added a commit that referenced this pull request Jan 7, 2025
@kibanamachine @delanni
[8.16] [CI] Prevent console.log in pipeline.ts (#204724) (#205712)
eed2962 
# Backport

This will backport the following commits from `main` to `8.16`:
- [[CI] Prevent console.log in pipeline.ts
(#204724)](#204724)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alex
Szabo","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-07T11:42:45Z","message":"[CI]
Prevent console.log in pipeline.ts (#204724)\n\n## Summary\n~Logging to
stdout from this file would result uploading the logged\nstring to
buildkite as a pipeline definition, causing
errors\n(https://buildkite.com/elastic/kibana-pull-request/builds/261721#0193d94b-f05c-41d6-9865-3d3c331a6cc4)~\n\nAdds
an inline eslint rule to warn about `console.log/stdout` usage, as\nthis
has happened before by oversight.\n\nOverlaps with:
https://github.com/elastic/kibana/pull/204672\n\n---------\n\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"ae6d0463192501f4a81ffbe58a85e5c87d9aaca8","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","v9.0.0","backport:prev-major"],"title":"[CI]
Remove unwanted console.log from
pipeline.ts","number":204724,"url":"https://github.com/elastic/kibana/pull/204724","mergeCommit":{"message":"[CI]
Prevent console.log in pipeline.ts (#204724)\n\n## Summary\n~Logging to
stdout from this file would result uploading the logged\nstring to
buildkite as a pipeline definition, causing
errors\n(https://buildkite.com/elastic/kibana-pull-request/builds/261721#0193d94b-f05c-41d6-9865-3d3c331a6cc4)~\n\nAdds
an inline eslint rule to warn about `console.log/stdout` usage, as\nthis
has happened before by oversight.\n\nOverlaps with:
https://github.com/elastic/kibana/pull/204672\n\n---------\n\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"ae6d0463192501f4a81ffbe58a85e5c87d9aaca8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204724","number":204724,"mergeCommit":{"message":"[CI]
Prevent console.log in pipeline.ts (#204724)\n\n## Summary\n~Logging to
stdout from this file would result uploading the logged\nstring to
buildkite as a pipeline definition, causing
errors\n(https://buildkite.com/elastic/kibana-pull-request/builds/261721#0193d94b-f05c-41d6-9865-3d3c331a6cc4)~\n\nAdds
an inline eslint rule to warn about `console.log/stdout` usage, as\nthis
has happened before by oversight.\n\nOverlaps with:
https://github.com/elastic/kibana/pull/204672\n\n---------\n\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"ae6d0463192501f4a81ffbe58a85e5c87d9aaca8"}}]}]
BACKPORT-->

Co-authored-by: Alex Szabo <[email protected]>
kowalczyk-krzysztof pushed a commit to kowalczyk-krzysztof/kibana that referenced this pull request Jan 7, 2025
@delanni @kibanamachine @kowalczyk-krzysztof
[CI] Prevent console.log in pipeline.ts (elastic#204724)
1075c05 
## Summary
~Logging to stdout from this file would result uploading the logged
string to buildkite as a pipeline definition, causing errors
(https://buildkite.com/elastic/kibana-pull-request/builds/261721#0193d94b-f05c-41d6-9865-3d3c331a6cc4)~

Adds an inline eslint rule to warn about `console.log/stdout` usage, as
this has happened before by oversight.

Overlaps with: elastic#204672

---------

Co-authored-by: kibanamachine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
@delanni @kibanamachine @CAWilson94
[CI] Prevent console.log in pipeline.ts (elastic#204724)
ab6af32 
## Summary
~Logging to stdout from this file would result uploading the logged
string to buildkite as a pipeline definition, causing errors
(https://buildkite.com/elastic/kibana-pull-request/builds/261721#0193d94b-f05c-41d6-9865-3d3c331a6cc4)~

Adds an inline eslint rule to warn about `console.log/stdout` usage, as
this has happened before by oversight.

Overlaps with: elastic#204672

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ikuni17 Ikuni17 Ikuni17 approved these changes

Assignees
No one assigned
Labels
backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.16.3 v8.17.1 v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@delanni @elasticmachine @kibanamachine @Ikuni17