Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Profiling UI, 9.0.0] Clean up unused ES fields that will be removed in 9.0.0 #204024

Closed
3 tasks done
Tracked by #106592
miloszmarcinkowski opened this issue Dec 12, 2024 · 6 comments · Fixed by #205499
Closed
3 tasks done
Tracked by #106592
Assignees
Labels
Feature:UniversalProfiling Universal Profiling observability feature Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v9.0.0

Comments

@miloszmarcinkowski
Copy link
Contributor

miloszmarcinkowski commented Dec 12, 2024

Meta issue
Related PR in ES

Clean up ES fields in Universal Profiling UI that are planned to be removed in 9.0.0.

AC:

The fields will be removed from ES once UI is ready.

@miloszmarcinkowski miloszmarcinkowski added Feature:UniversalProfiling Universal Profiling observability feature Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v9.0.0 labels Dec 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@rockdaboot
Copy link
Contributor

rockdaboot commented Dec 13, 2024

[Profiling, 9.0.0] Remove backwards compatibility code in CO2 calculator
(TBD) how is it going to affect API? @UpdateForV9 annotation

We have to keep this because older 8.x agents may still send the old values. And we try to make transition from 8.x to 9.x as smooth as possible for customers. Best mark this for V10 to be removed.

The effect for customers with 8.x data could be wrong calculated CO2 emission values.

@rockdaboot
Copy link
Contributor

rockdaboot commented Dec 13, 2024

[Profiling, 9.0.0] Remove backwards compatibility code for host.arch
(TBD) how is it going to affect API? @UpdateForV9 annotation

Let's keep it, similar reasoning as before.

Though, we can drop the field from the profiling-hosts mapping. In 9.x it won't be written to it any more. But the read path (pre 8.14 fallback) should be left intact for old 8.x data (customer may update from 8.x to 9.x without removing data).

Thanks for raising this: The agent code needs to be amended for 9.x (throw out legacy compat code) 😄.

@rockdaboot
Copy link
Contributor

rockdaboot commented Jan 7, 2025

[Profiling, 9.0.0] Remove backwards compatibility for missing cloud.provider, cloud.region, host.type

Let's keep it, similar reasoning as before (8.x data may still be present after upgrading).

@rockdaboot
Copy link
Contributor

(TBD) renderLegacyXContent field

Addressed with elastic/elasticsearch#119770

@rockdaboot
Copy link
Contributor

TotalSamples != CountInclusive[0]

This is often not true, see the description of #106593 under UPDATE.

delanni pushed a commit to delanni/kibana that referenced this issue Jan 13, 2025
Closes elastic#204024

## Summary

This PR removes unused ES fields from Profiling UI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:UniversalProfiling Universal Profiling observability feature Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v9.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants