-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Profiling UI, 9.0.0] Clean up unused ES fields that will be removed in 9.0.0 #204024
Comments
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
We have to keep this because older 8.x agents may still send the old values. And we try to make transition from 8.x to 9.x as smooth as possible for customers. Best mark this for V10 to be removed. The effect for customers with 8.x data could be wrong calculated CO2 emission values. |
Let's keep it, similar reasoning as before. Though, we can drop the field from the Thanks for raising this: The agent code needs to be amended for 9.x (throw out legacy compat code) 😄. |
Let's keep it, similar reasoning as before (8.x data may still be present after upgrading). |
Addressed with elastic/elasticsearch#119770 |
This is often not true, see the description of #106593 under |
Closes elastic#204024 ## Summary This PR removes unused ES fields from Profiling UI.
Meta issue
Related PR in ES
Clean up ES fields in Universal Profiling UI that are planned to be removed in 9.0.0.
AC:
total_frames
(TBD) replace(values are different, the latter migth be missing some events)stack_trace_events
withstack_traces.[key].count
TotalCPU
(TBD) replace(we didn't find alternative for replacement)TotalSamples
withselfCPU
orCountInclusive[0]
(there is difference in valueTotalSamples
!=CountInclusive[0]
(butselfCPU
=CountInclusive[0]
))[Profiling, 9.0.0] Remove backwards compatibility code in CO2 calculator(TBD) how is it going to affect API? @UpdateForV9 annotationmoving change to v10[Profiling, 9.0.0] Remove backwards compatibility code for host.arch(TBD) how is it going to affect API? @UpdateForV9 annotationmoving change to v10[Profiling, 9.0.0] Remove backwards compatibility for missing cloud.provider, cloud.region, host.type(TBD) how is it going to affect API? @UpdateForV9 annotationaggregation_field
query inGetStackTracesRequest
@UpdateForV9 annotation @UpdateForV9 annotation(TBD)(doesn't affect ES API)renderLegacyXContent
field @UpdateForV9 annotation(TBD) Coordinate the process of removing ES fields so it can be tested against updated UI (making sure that nothing got broken)The fields will be removed from ES once UI is ready.
The text was updated successfully, but these errors were encountered: