Eui Refresh #204007
Open
Eui Refresh #204007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…risk severity updated to use RISK_SEVERITY_COLOUR instead of SEVERITY_COLOUR
CAWilson94
commented
Dec 12, 2024
| low_impact: '#54B399', | ||
| unassigned: euiLightVars.euiColorMediumShade, | ||
| }; | ||
| import { useCriticalityLevelColors } from '../../hooks/use_criticality_level_colors'; |
There was a problem hiding this comment.
Moved this to a hook in the hooks folder. Noticed some hooks in asset_criticality aren’t in hooks; both locations make sense, but this follows a better convention.
CAWilson94
commented
Dec 12, 2024
| import { RiskSeverity } from '../../../../../common/search_strategy'; | ||
| import { RiskScoreLevel } from '.'; | ||
| import { SEVERITY_COLOR } from '../../../../overview/components/detection_response/utils'; | ||
| import { RISK_SEVERITY_COLOUR } from '../../../common/utils'; |
There was a problem hiding this comment.
Updated RISK_SEVERITY_COLOUR to match updates previously made to index from SEVERITY --> RISK_SEVERITY
CAWilson94
commented
Dec 12, 2024
| </RiskBadge> | ||
| )); | ||
| }> = React.memo(({ severity, hideBackgroundColor = false, 'data-test-subj': dataTestSubj }) => { | ||
| const { euiTheme } = useEuiTheme(); |
There was a problem hiding this comment.
This is the change
CAWilson94
commented
Dec 12, 2024
| const { euiTheme } = useEuiTheme(); | ||
| return ( | ||
| <RiskBadge | ||
| color={euiTheme.colors.danger} |
There was a problem hiding this comment.
along with this change, the others I think just formatter
…n in place, to change references WiP
…uiTheme hook for colors
… - WiP consider moving back to static mapping if eui can allow
CAWilson94
added
ci:project-deploy-security
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
|
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
CAWilson94
added
the
release_note:feature
…regardless of availability within euicolorVis library
… themes; ordering on criticality colors matching
mgadewoll
requested changes
Dec 17, 2024
x-pack/plugins/security_solution/public/entity_analytics/common/utils.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/entity_analytics/common/utils.ts
Outdated
Show resolved
Hide resolved
...c/entity_analytics/components/asset_criticality_file_uploader/components/validation_step.tsx
Outdated
Show resolved
Hide resolved
...ns/security_solution/public/entity_analytics/components/risk_summary_flyout/risk_summary.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/entity_analytics/components/severity/common/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/entity_analytics/components/severity/common/index.tsx
Outdated
Show resolved
Hide resolved
mgadewoll
reviewed
Dec 17, 2024
x-pack/plugins/security_solution/public/entity_analytics/common/utils.ts
Outdated
Show resolved
Hide resolved
PhilippeOberti
approved these changes
Dec 26, 2024
...rity/plugins/security_solution/public/entity_analytics/hooks/use_criticality_level_colors.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @CAWilson94 |
mgadewoll
reviewed
Jan 8, 2025
| @@ -27,6 +27,14 @@ jest.mock('uuid', () => ({ | |||
| v4: jest.fn().mockReturnValue('2cc5663b-f062-43f8-8688-fc8166c2ca8e'), | |||
| })); | |||
|
|
|||
| const riskColors = { | |||
There was a problem hiding this comment.
Question: To clarify - Will these also be updated with the shared colors? As these are currently not accounting for themes 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR covers required updates for EUI refresh.
The updates should only cover Entity Owned components.
This PR does not include severity color changes - this will be added in a follow-up once tokens are decided. @angorayc is working on a shared security solution colors hook, which will replace the EA-specific hook (previous criticality colors hook has been reverted for this reason).
Testing
Running Kibana with the Borealis theme
In order to run Kibana with Borealis, you'll need to do the following:
Set the following in kibana.dev.yml: uiSettings.experimental.themeSwitcherEnabled: true
Run Kibana with the following environment variable set:
KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn start
This will expose a toggle under Stack Management > Advanced Settings > Theme version, which you can use to toggle between Amsterdam and Borealis.
More details about each section #199715
Main change for color utility function - file_picker_step.tsx which shows on Entity Risk Score Page
Borealis Updates Light & Dark Theme
Screenshots
Quite a few here:
https://docs.google.com/document/d/1tKPoqCPbccX94cqgPyHKBdr9_K3kmqveQGkcGo_Q8k4/edit?usp=sharing
Quick Walkthrough Video
video1950532074.mp4