-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review How We Present Empty, Null, Undefined Values #190174
Comments
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
We believe this should be approached holistically and globally in Kibana, not just in Lens, but also everywhere else. It would be great if Design could provide the right guidance to follow in all the proposed cases and any other cases where values are missing/undefined/null/not-available. |
Thanks, @markov00. I'll bring it up as an agenda item in the patterns working group to see if this is something the design team can provide some guidance around. |
tagging myself to follow the discussion @gvnmagni |
Update: I've spoken with the patterns working group. The general consensus was that:
I will plan to write up a document for adoption into our official UX patterns library and share here for visibility. Stay tuned. |
Currently in Lens, it can be difficult to distinguish actual empty, null, and undefined values from their string counterparts. For example:
(empty)
to represent an empty value. However, this is nearly indistinguishable from an actual string value of "(empty)". The only visual indicator is the use ofsubdued
text color.-
to represent a null value. This is indistinguishable from an actual string value of "-".Here's a helpful POC, provided by @nickofthyme, below shows the example values in code form and string form.
Should we reconsider how we are presenting these values in Lens visualizations? Should they be visually offset (italics, icon, color, etc.) in some way that indicates they are not simply a string value? As part of the forthcoming addition of color-by-term support to tables, we are planning to identify these special values with a prefixed
asterisk
icon, italic font, and accompanying descriptive text in the color mapping interface. Should we take a similar approach in our visualizations? Or perhaps indicate the values with anEuiCode
component? Or leave as is? Assuming we do wish to make changes, we should also ensure that other Kibana apps (such as Discover) take the same approach for consistency.CCing @nickofthyme, @teresaalvarezsoler.
The text was updated successfully, but these errors were encountered: