[APM] Service icons metadata endpoint doesn't apply environment filter

[kpatticha]

We didn't consider the case where each environment could use different cloud provider or platform.

kibana/x-pack/plugins/apm/server/routes/services/route.ts

Lines 282 to 311 in beff74e

	const serviceMetadataIconsRoute = createApmServerRoute({
	endpoint: 'GET /internal/apm/services/{serviceName}/metadata/icons',
	params: t.type({
	path: t.type({ serviceName: t.string }),
	query: rangeRt,
	}),
	options: { tags: ['access:apm'] },
	handler: async (resources): Promise<ServiceMetadataIcons> => {
	const apmEventClient = await getApmEventClient(resources);
	const { params, config } = resources;
	const { serviceName } = params.path;
	const { start, end } = params.query;
	const searchAggregatedTransactions = await getSearchTransactionsEvents({
	apmEventClient,
	config,
	start,
	end,
	kuery: '',
	});
	return getServiceMetadataIcons({
	serviceName,
	apmEventClient,
	searchAggregatedTransactions,
	start,
	end,
	});
	},
	});

[elasticmachine]

Pinging @elastic/apm-ui (Team:APM)

[elasticmachine]

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

[neptunian]

@kpatticha Since the query only returns one document, I think that could be the problem where no value is returned. I tried querying my edge cluster data and was able to get documents that have no values:

GET /metrics-apm*,apm-*,logs-apm*/_search
{
  "size": 10,
  "query": {
    "bool": {
      "must_not": [
        {
          "exists": {
            "field": "cloud.provider"
          }
        }
      ],
      "filter": [
        {
          "term": {
            "service.name": "heartbeat"
          }
        },
        {
          "range": {
            "@timestamp": {
              "gte": "now-15m/m",
              "lte": "now"
            }
          }
        }
      ]
    }
  },
  "aggs": {
    "by_environment": {
      "terms": {
        "field": "service.environment",
        "size": 10
      },
      "aggs": {
        "missing_cloud_provider_count": {
          "missing": {
            "field": "cloud.provider"
          }
        }
      }
    }
  }
}

It seems like it could be possible that no value is returned for cloud.provider if it falls out of the time range or the highest ranked document doesn't include this field because it includes the other fields.

[botelastic]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.