Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML Diff: "hide" links on cleannet.org erroneously highlighted #25

Open
Mr0grog opened this issue Mar 18, 2020 · 0 comments
Open

HTML Diff: "hide" links on cleannet.org erroneously highlighted #25

Mr0grog opened this issue Mar 18, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@Mr0grog
Copy link
Member

Mr0grog commented Mar 18, 2020

“Hide” links that show/hide captions are getting highlighted even though they haven’t meaningfully changed on cleannet.org pages.

For example, on this page: https://monitoring.envirodatagov.org/page/418909c5-1b9e-4b94-a46d-1cb36decadb1/da49eacc-5a93-4fdf-b9bc-e31c00fa2638..d01f6684-23a4-4e4a-9cd5-3f58d8b88d6f

hide-links-changed

I think it’s because they are javascript: links and the IDs of the elements they are affecting have changed:

hide-links-changed-source

I’m wondering whether it makes sense to ignore the URL change for javascript: links, since it seems reasonable to presume they conceptually/functionally the same if in the same place and on the same content.

@Mr0grog Mr0grog transferred this issue from edgi-govdata-archiving/web-monitoring-processing Oct 26, 2020
@stale stale bot added the stale label Jun 2, 2021
@edgi-govdata-archiving edgi-govdata-archiving deleted a comment from stale bot Jun 4, 2021
@stale stale bot removed the stale label Jun 4, 2021
@Mr0grog Mr0grog added the bug Something isn't working label Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant