Can't format files with EJS inside opening HTML tags #11

manuhabitela · 2024-03-11T11:38:29Z

Hi 👋

Thanks for the plugin :)

It seems I have an issue very similar to this closed one: #8

For example, prettier can't format this piece of code:

<button class="fr-btn" type="submit" <% if (locals.ariaLabel) { %>aria-label="<%= locals.ariaLabel %>"<% } %>>
    <%= label %>
</button>

Because of the test inside the button opening tag:

[error] src/[...].ejs: SyntaxError: Opening tag "button" not terminated. (14:5)
[error]   12 |         <% } %>
[error]   13 |     </span>
[error] > 14 |     <button class="fr-btn" type="submit" <% if (locals.ariaLabel) { %>aria-label="<%= locals.ariaLabel %>"<% } %>>
[error]      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[error]   15 |         <%= label %>
[error]   16 |     </button>
[error]   17 | </div>

I'm using the latest plugin version and latest prettier version. I also tried the nested EJS example in the readme and it crashes too.

Is there something I missed? Thanks!

thomaspatrickwelborn · 2024-06-19T14:18:28Z

Experienced the same issue where a Syntax Error is generated when EJS closures occur within Markup Element Start Tag.

Prettier v3.3.2

Example A

INPUT

<!DOCTYPE html5>
<html lang="en">
  <head>
    <title></title>
    <% for (const $meta of $data.content.meta) { %>
      <meta 
        <% for(const $metaAttribute of $meta.attributes) { %>
	      <%= $metaAttr.key %>="<%= $metaAttr.val %>"
        <% } %>
      />
    <% } %>
  </head>
  <body>
  </body>
</html>

OUTPUT

SyntaxError: Opening tag "meta" not terminated. (6:7)
   4 |     <title></title>
   5 |     <% for (const $meta of $data.content.meta) { %>
>  6 |       <meta 
     |       ^^^^^^
>  7 |         <% for(const $metaAttribute of $meta.attributes) { %>
     | ^^^^^^^^^
   8 | 	      <%= $metaAttr.key %>="<%= $metaAttr.val %>"
   9 |         <% } %>
  10 |       />

Example B

It also appears that one of the given tests from the README fails, FYI:

INPUT

<td <% if (styleData) { %>
  style="<%= styleData %>" <% } %>>
  <%= data %>
  <%= data %>
</td>`

OUTPUT

SyntaxError: Opening tag "td" not terminated.
> 1 | <td <% if (styleData) { %>
    | ^^^^
  2 |   style="<%= styleData %>" <% } %>>
  3 |   <%= data %>
  4 |   <%= data %>

sduzair · 2024-07-30T02:52:53Z

@thomaspatrickwelborn I experienced the same issue. I am using the older prettier 2.8.8 as a workaround

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Can't format files with EJS inside opening HTML tags #11

Can't format files with EJS inside opening HTML tags #11

manuhabitela commented Mar 11, 2024 •

edited

Loading

thomaspatrickwelborn commented Jun 19, 2024 •

edited

Loading

sduzair commented Jul 30, 2024

Can't format files with EJS inside opening HTML tags #11

Can't format files with EJS inside opening HTML tags #11

Comments

manuhabitela commented Mar 11, 2024 • edited Loading

thomaspatrickwelborn commented Jun 19, 2024 • edited Loading

Example A

Example B

sduzair commented Jul 30, 2024

manuhabitela commented Mar 11, 2024 •

edited

Loading

thomaspatrickwelborn commented Jun 19, 2024 •

edited

Loading