ArrowEdgeView TargetAnchorCorrection

[glsp-bot]

Hey I am currently analyzing #57.

I have a question regarding the method getTargetAnchorCorrection in the class ArrowEdgeView:

Is this at the right place? I would assume that this method can be omitted here. I haven't seen any case where this is called. In my opinion this information should be put into a class, which extends the SEdge, as the ManhattanRouter picks the correction information from the model/SEdge.

original thread by Jonas Ebel

[planger]

Hi,
yes, here you can set a value to correct the anchor position.
In general, for computing the anchor at an element, two sides are involved:

1. the registered IEdgeRouter (e.g. ManhattanEdgeRouter) that computes the route of an SRoutableElement, such as the ArrowEdgeView, which actually reads the anchor correction.

2. the registered IAnchorComputer, such as the ManhattanRectangularAnchor.

Those concepts actually come from Sprotty, as they are concerned with the client-side rendering.
Assuming that the IAnchorComputer for a rectangle is correct, I think you're better off starting to debug from the IEdgeRouter side. Hope that helps!
Note that there seems to be an open PR already for that issue: eclipsesource/ecore-glsp#68

[tortmayr]

Hi Jonas,
you are completely right the getTargetAnchorCorrection in ArrowEdgeView is deprecated and can be omitted. Sprotty did an API redesign a while back witch moved the anchor correction calculation to the EdgeRouter (eclipse-sprotty/sprotty#51). As you already noticed anchor corrections are now applied directly in the underlyingSEdge class.