Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catastrophic failure - Saving any new tab set #27

Open
djayfresh opened this issue Mar 12, 2020 · 0 comments · May be fixed by #28
Open

Catastrophic failure - Saving any new tab set #27

djayfresh opened this issue Mar 12, 2020 · 0 comments · May be fixed by #28

Comments

@djayfresh
Copy link

Attempting to save a new tab set causes a Catastrophic Failure message to appear in VS 2017. After trying to save again, the following error happens and VS crashes and restarts.

Application: devenv.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.Runtime.InteropServices.COMException
   at System.Runtime.InteropServices.Marshal.ThrowExceptionForHRInternal(Int32, IntPtr)
   at Microsoft.VisualStudio.Shell.Settings.ShellWritableSettingsStore.SetString(System.String, System.String, System.String)
   at SaveAllTheTabs.DocumentManager.SaveGroupsForSolution(System.Collections.Generic.IList`1<SaveAllTheTabs.DocumentGroup>)
   at SaveAllTheTabs.DocumentManager.<LoadGroups>b__25_2(System.Reactive.EventPattern`1<System.ComponentModel.PropertyChangedEventArgs>)
   at System.Reactive.AnonymousSafeObserver`1[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].OnNext(System.__Canon)
   at System.Reactive.Concurrency.ObserveOn`1+ObserveOnSink[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].OnNextPosted(System.Object)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate, System.Object, Int32)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate)
   at System.Windows.Threading.DispatcherOperation.InvokeImpl()
   at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(System.Object)
   at MS.Internal.CulturePreservingExecutionContext.CallbackWrapper(System.Object)
   at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object)
   at MS.Internal.CulturePreservingExecutionContext.Run(MS.Internal.CulturePreservingExecutionContext, System.Threading.ContextCallback, System.Object)
   at System.Windows.Threading.DispatcherOperation.Invoke()
   at System.Windows.Threading.Dispatcher.ProcessQueue()
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef)
   at MS.Win32.HwndWrapper.WndProc(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(System.Object)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate, System.Object, Int32)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate)
   at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(System.Windows.Threading.DispatcherPriority, System.TimeSpan, System.Delegate, System.Object, Int32)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr, Int32, IntPtr, IntPtr)

Visual Studio Info:
Microsoft Visual Studio Professional 2017
Version 15.9.21
VisualStudio.15.Release/15.9.21+28307.1064
Microsoft .NET Framework
Version 4.8.03761
Save All the Tabs 1.0
SaveAllTheTabs Visual Studio Package Detailed Info

System Info:
Windows 10 Pro x64
32GB - RAM
Intel i9-8950HK @ 2.9GHz
andronov-alexey pushed a commit to andronov-alexey/SaveAllTheTabs that referenced this issue Jun 14, 2020
Store each group individually in registry
84fda6d 
Resolves eamodio#27
andronov-alexey pushed a commit to andronov-alexey/SaveAllTheTabs that referenced this issue Jun 14, 2020
Store each group individually in registry
889ff18 
Resolves eamodio#27
andronov-alexey pushed a commit to andronov-alexey/SaveAllTheTabs that referenced this issue Jun 14, 2020
Store each group individually in registry
2549cdb 
Resolves eamodio#27
@andronov-alexey andronov-alexey linked a pull request Jun 14, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix exception on saving many tab groups andronov-alexey/SaveAllTheTabs
1 participant
@djayfresh