Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Runtime Performance Tests #21267

Open
mellinoe opened this issue Apr 21, 2017 · 1 comment
Open

System.Runtime Performance Tests #21267

mellinoe opened this issue Apr 21, 2017 · 1 comment
Labels
area-System.Runtime backlog-cleanup-candidate An inactive issue that has been marked for automated closure. help wanted [up-for-grabs] Good issue for external contributors no-recent-activity tenet-performance Performance related issue test-enhancement Improvements of test source code
Milestone

Comments

@mellinoe
Copy link
Contributor

This is a tracking issue describing the current performance tests we have in the System.Runtime area, and what coverage is missing. The work items below can be completed independently, and they are all of different priority.

When adding performance tests, please adhere to the guidelines listed here.

NOTE: System.Runtime is a broad area. I have split out types that "obviously" belong to other areas, like Reflection and Globalization, into other issues where they can be tracked alongside the rest of the area.

Existing Coverage

We have some basic coverage for common types, but the test cases need to be audited for conformance with the guidelines:

  • Most tests are far too short: they should be 100 - 1000 ms long.
  • Some test cases are being optimized out completely, leading to bogus data. See https://github.com/dotnet/corefx/issues/18416.
  • Some tests seem redundant and should be trimmed.
    • System.String has a very large number of tests -- necessary or excessive?

Missing Coverage

  • Primitive numeric types have no coverage for operators
  • Missing coverage for (S)Byte (U)Int16, (U)Int64, Single entirely
  • Char -- We have minimal tests here. Many un-tested methods are not critical, but some coverage should be added here.
  • Activator
  • AppContext
  • Array
  • ArraySegment
  • Buffer
  • DateTime -- some coverage, but there are a ton of additional operations that may be interesting.
  • Decimal
  • Delegate
  • Enum -- some coverage already. GetNames(), GetValues(), IsDefined() are also important.
  • FormattableString
  • Nullable
  • TimeSpan -- Needs extra coverage
  • Uri
  • ValueTuple
  • WeakReference, WeakReference
  • ConditionalWeakTable<TKey, TValue>
  • RuntimeHelpers
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 23, 2020
@joperezr joperezr removed the untriaged New issue has not been triaged by the area owner label Jul 1, 2020
Copy link
Contributor

Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.

This process is part of our issue cleanup automation.

@dotnet-policy-service dotnet-policy-service bot added backlog-cleanup-candidate An inactive issue that has been marked for automated closure. no-recent-activity labels Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Runtime backlog-cleanup-candidate An inactive issue that has been marked for automated closure. help wanted [up-for-grabs] Good issue for external contributors no-recent-activity tenet-performance Performance related issue test-enhancement Improvements of test source code
Projects
None yet
Development

No branches or pull requests

4 participants