Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Linux/arm64: System.Text.RegularExpressions.Tests.Perf_Regex_Industry_RustLang_Sherlock Regressions on 12/6/2024 6:16:01 PM #110661

Open
performanceautofiler bot opened this issue Dec 12, 2024 · 5 comments
Labels
arch-arm64 area-System.Text.RegularExpressions os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark untriaged New issue has not been triaged by the area owner

Comments

@performanceautofiler
Copy link

Run Information

Name Value
Architecture arm64
OS ubuntu 22.04
Queue AmpereUbuntu
Baseline 2f8151352a759e682de49dab04cb5081185f2454
Compare 2d81cbb28a8feb1af5b790664b511b264d032877
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Text.RegularExpressions.Tests.Perf_Regex_Industry_RustLang_Sherlock

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
207.97 μs 219.74 μs 1.06 0.01 False
2.32 ms 2.48 ms 1.07 0.02 False

graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Text.RegularExpressions.Tests.Perf_Regex_Industry_RustLang_Sherlock*'

System.Text.RegularExpressions.Tests.Perf_Regex_Industry_RustLang_Sherlock.Count(Pattern: "Sherlock|Holmes|Watson", Options: Compiled)

ETL Files

Histogram

JIT Disasms

System.Text.RegularExpressions.Tests.Perf_Regex_Industry_RustLang_Sherlock.Count(Pattern: "\p{Lu}", Options: None)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added arch-arm64 os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime untriaged New issue has not been triaged by the area owner labels Dec 12, 2024
@LoopedBard3 LoopedBard3 transferred this issue from dotnet/perf-autofiling-issues Dec 12, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

@LoopedBard3
Copy link
Member

Most likely #109283 from range 8fca0a1...c7f4149. FYI @stephentoub.

@LoopedBard3 LoopedBard3 added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels Dec 12, 2024
@LoopedBard3 LoopedBard3 changed the title [Perf] Linux/arm64: 2 Regressions on 12/6/2024 6:16:01 PM [Perf] Linux/arm64: System.Text.RegularExpressions.Tests.Perf_Regex_Industry_RustLang_Sherlock Regressions on 12/6/2024 6:16:01 PM Dec 12, 2024
@stephentoub
Copy link
Member

Most likely #109283 from range 8fca0a1...c7f4149. FYI @stephentoub.

It'd be odd for this to have any meaningful impact on throughput. It's effectively adding a null check as part of compilation, but it should have zero impact on the generated IL for the dynamic method.

@steveharter
Copy link
Member

@LoopedBard3 can you provide a new historical run of this benchmark to see if it stabilized or not?

@LoopedBard3
Copy link
Member

The reports should be updated, one way to access them would be to use the Benchmark links starting with "Count - " and clicking the graph in the difference column on the linked page.
Otherwise, here are the updated graphs up through the 30th:
Image
Image

It seems both are still displaying the bimodal behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-arm64 area-System.Text.RegularExpressions os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark untriaged New issue has not been triaged by the area owner
Projects
None yet
Development

No branches or pull requests

3 participants