Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Imprint does not restore rolls #7

Open
AR-234 opened this issue Apr 13, 2022 · 3 comments
Open

[Improvement] Imprint does not restore rolls #7

AR-234 opened this issue Apr 13, 2022 · 3 comments

Comments

@AR-234
Copy link
Contributor

AR-234 commented Apr 13, 2022

Imprint dont restore the rolled value.
The tier stays the same but doesn't keep the roll.

@doomeer
Copy link
Owner

doomeer commented Apr 13, 2022

Actually I don't store the roll, I display random ones everytime the item is displayed. It is confusing, in particular when reforge keeping prefixes or splitting, but I also think that it is not very high priority to store them (and it would also slow down the program a little bit). A quick change I could do is to always display the average roll, what do you think?

@AR-234
Copy link
Contributor Author

AR-234 commented Apr 14, 2022

Would be just a minor improvement, and shouldn't be high on the priority list, other currency support is far more important.
Opened this issue only to keep track of it. If not needed just close it.

Maybe just store the rolls in the imprint and when the imprint is applied set the rolls to its previous values.

@AR-234
Copy link
Contributor Author

AR-234 commented Apr 24, 2022

Rolls for divine lucky harvest craft #10, posted here for visibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants