Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add speed test ticking a tween #62

Open
djeedai opened this issue Oct 1, 2022 · 0 comments
Open

Add speed test ticking a tween #62

djeedai opened this issue Oct 1, 2022 · 0 comments
Labels
testing Testing-related item

Comments

@djeedai
Copy link
Owner

djeedai commented Oct 1, 2022

Add an animator speed test which actually ticks a tween. Currently because the ticking is deferred to the tween itself, and applied "manually" by the built-in animator systems, it's easy to break the feature without noticing as the systems are also not tested.
@djeedai djeedai added the testing Testing-related item label Oct 1, 2022
djeedai added a commit that referenced this issue Oct 1, 2022
@djeedai
Fix animator speed feature
c6c2c21 
Fix the animator speed applying, which got broken as part of the
refactor of #44. Add some simple test for speed, but this is not enough
to make sure the feature doesn't regress, so logged #62 to follow-up
with a proper regression test.

Fixes #61
djeedai added a commit that referenced this issue Oct 1, 2022
@djeedai
Fix animator speed feature
411a380 
Fix the animator speed applying, which got broken as part of the
refactor of #44.

Add a `speed()` getter to both `Animator<T>` and `AssetAnimator<T>`.

Add some simple test for speed, but this is not enough to make sure the
feature doesn't regress, so logged #62 to follow-up with a proper
regression test.

Fixes #61
djeedai added a commit that referenced this issue Oct 1, 2022
@djeedai
Fix animator speed feature
37b436f 
Fix the animator speed applying, which got broken as part of the
refactor of #44.

Add a `speed()` getter to both `Animator<T>` and `AssetAnimator<T>`.

Add some simple test for speed, but this is not enough to make sure the
feature doesn't regress, so logged #62 to follow-up with a proper
regression test.

Fixes #61
@djeedai djeedai mentioned this issue Oct 1, 2022
Merged
djeedai added a commit that referenced this issue Oct 1, 2022
@djeedai
Fix animator speed feature (#63)
4c2f49d 
Fix the animator speed applying, which got broken as part of the
refactor of #44.

Add a `speed()` getter to both `Animator<T>` and `AssetAnimator<T>`.

Add some simple test for speed, but this is not enough to make sure the
feature doesn't regress, so logged #62 to follow-up with a proper
regression test.

Fixes #61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing Testing-related item
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@djeedai