Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Allow binding keys to diagonal movement #7607

Open
sidav opened this issue Dec 28, 2024 · 6 comments
Open

[Feature Request]: Allow binding keys to diagonal movement #7607

sidav opened this issue Dec 28, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@sidav
Copy link

sidav commented Dec 28, 2024

Feature Type

Gamepad Controls

Describe

On devices like Miyoo Mini, where there are no diagonals on the D-Pad, the gameplay is not that comfortable because it's not possible to bind e.g. "d-pad up" to "move up and right". Example of where it's needed is the bridge that leads to Adria - I just press the "D-pad down" and "D-pad right" with two fingers.
It would be great to have separate bind options for diagonal movement.

@sidav sidav added the enhancement New feature or request label Dec 28, 2024
@AJenbo
Copy link
Member

AJenbo commented Dec 28, 2024

What would you bind it to? How would you move to the right if the right button is mapped to south east?

It works perfectly fine on RG300 which has a similar d-pad:

image

If you cannot push the d-pad in a diagonal direction with on finger there will be a lot of games designed for dpad that won't be very playable.

  • Contra series
  • Sonic Advance
  • Metal Gear
  • Street Fighter
  • Tetris Attack

@sidav
Copy link
Author

sidav commented Dec 28, 2024

I'd simply bind it to the D-Pad and unbind the non-diagonals.

How would you move to the right if the right button is mapped to south east?

Via moving south-east and then north-east. I don't remember any places in the game where moving in cardinal directions is strictly neccessary, whereas there are tons of them where moving diagonally is.

@Trihedraf
Copy link
Collaborator

What are you talking about? Diagonals work just fine on miyoo mini. https://github.com/user-attachments/assets/54ec7826-d48c-4ce2-9568-07fcab5512c3

What version of DevilutionX are your running and where did you get it?

@AJenbo
Copy link
Member

AJenbo commented Dec 28, 2024

I guess your assumption is that it would be implemented in a way where pushing two diagonals would result in a non diagonal.

@sidav
Copy link
Author

sidav commented Dec 28, 2024

I guess your assumption is that it would be implemented in a way where pushing two diagonals would result in a non diagonal.

Why would this be needed?
My assumption is that it's possible to play without the non-diagonal movement altogether, as there are no places in the whole game which you can't reach without those "cardinal directions", so you actually wouldn't need pressing two keys simultaneously anywhere. From the other hand, there are tons of places where you can't reach with those cardinals only, because all the bridges, doors etc are placed diagonally. Even the level architecture is "diagonal" in the whole game. When I'm playing with mouse, I'm pretty sure I move diagonally more than cardinally because of that.

What are you talking about? Diagonals work just fine on miyoo mini. https://github.com/user-attachments/assets/54ec7826-d48c-4ce2-9568-07fcab5512c3
What version of DevilutionX are your running and where did you get it?

It seems it's not a problem with any version, it seems more like a problem with my fingers. I can't do like you do in the video with a single thumb, as I can reliably get diagonal movement with two finger press only. Too small thumbs, idk. Well, I just thought this request wouldn't be too complicated to implement and it's not game breaking in any way (as this movement already is in the game, it's just not directly accessible), and it may be fully optional, as it's just a keybind.
Thanks for the attention anyways.

@AJenbo
Copy link
Member

AJenbo commented Dec 31, 2024

Hm it's possible that would work. I'll leave the issue open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants