Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple login provider #155

Open
torgeirl opened this issue Feb 9, 2024 · 0 comments
Open

Support for multiple login provider #155

torgeirl opened this issue Feb 9, 2024 · 0 comments
Assignees
Milestone

Comments

@torgeirl
Copy link
Contributor

torgeirl commented Feb 9, 2024

Trix's OpenID Connect (OIDC) support is focused around one provider (Dataporten), but it would be good to make it provider agnostic so that we can either switch to another provider if-need-be or run multiple providers simultaneously.

We should:

  • remove hard references to Dataporten as login provider in the code ✔️
  • move login provider config from SocialApp (Django Admin) to settings.py ✔️
  • allow multiple login providers in parallel ✔️
  • when more than one login provider is available, the users should be asked to choose ✔️
  • display the name of current login provider (if any) next to last login details on /user/ ✔️

TO-DOs

  • remove or fix (link back to origin?) burger menu on login provider selection page
  • find a less hacky solution for adding logout URLs and expected responses
  • translations for login provider selection page (Translations for login provider selection #158)

Known issues

  • if you log in using an Allauth OpenID Connect provider you have used before, but with another login backend offered by that identify provider (IdP) you get stuck at /authenticate/allauth/3rdparty/signup/. I suspect the issue is that the Django user object is already associated with a SocialAccount from that provider, but that the response can't be overwritten the SocialAccount from the provider's other login backend.
@torgeirl torgeirl added this to the Trix 4.2 milestone Feb 9, 2024
@torgeirl torgeirl self-assigned this Feb 9, 2024
@torgeirl torgeirl changed the title Make allauth_adapter provider agnostic Make allauth adapter provider agnostic May 3, 2024
@torgeirl torgeirl changed the title Make allauth adapter provider agnostic Support for multiple login provider Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant