-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for @covers
alt annotation for Test Classes
#351
Comments
According to the docs it can be both though: Bear in mind that currently |
I'm not really sure why, but running
As a developer, I would rather not have both of those annotations in my header, though they may both be valid.
Are you saying the plugin should use |
Uses is the one for IDEs and clickable afaik |
So since this plugin is the “IDE Helper” then it’s only responsibility
should be the @uses tags and not the @Covers?
I’m pretty sure that’s the current behavior, which is logical in a certain
sense, but I do think that @Covers is a very common use case for test
annotations.
…On Mon, Apr 29, 2024 at 16:33 Mark Scherer ***@***.***> wrote:
Uses is the one for IDEs and clickable afaik
—
Reply to this email directly, view it on GitHub
<#351 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTV2XWJ677XBTSNMWP2HD3Y72VDDAVCNFSM6AAAAABGC5LKP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBTGYYTGNZVG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
We can add it on top or configure the Covers instead of uses. But uses should probably stay default |
Right now only
@uses
is supported, and it's my understanding that the semantics between@covers
and@uses
are different in PHPUnit. See: https://edorian.github.io/2011-11-04-An-introduction-to-phpunits-covers-annotation/I don't believe you can have both...which means every time we run 'bin/cake annotate' we have to remove lots of
@uses
statements from our tests which already have@covers
annotations.Would also need to update the logic to check for either
@uses
or@covers
already on the class, and not add a new unnecessary annotation.The text was updated successfully, but these errors were encountered: