#[class(inherit)] by default?

[dsherret]

Maybe this should be #[class(inherit)] by default?

#[derive(Debug, Error, JsError)]
pub enum FetchNoFollowErrorKind {
  #[class(inherit)] // don't require this?
  #[error(transparent)]
  ReadingFile(FailedReadingLocalFileError),

[crowlKats]

I think this makes it too easy to accidentally miss setting the class, which given the situation with all these multiple macros, is quite easily missed

[dsherret]

I was thinking this because I thought requiring it makes it too easy to accidentally override what the transparent error defines for its class. So it’s easy to end up in a scenario where the same error has different class names. Maybe it’s not possible to analyze for this in the macro though? It would maybe be nice for it to at least error when overriding a class name, but maybe not possible.

[crowlKats]

yeah not really possible for it to be completely correct.
sadly we do have cases where we want to overwrite the error, so this wouldnt be desireable either way