Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be able to use back/forwards navigation after changing search query in Top Cards, Cube Analysis, etc. #2457

Open
oscarhermoso opened this issue Jun 7, 2024 · 0 comments

Comments

@oscarhermoso
Copy link
Contributor

Describe the bug
Should be able to use back/forwards browser navigation after "Apply" / "Quick Filter" in Top Cards, Cube Analysis, etc. pages. (anywhere that uses the FilterCollapse component)

To Reproduce
Steps to reproduce the behavior:

  1. From any other page on the site, follow Nav Bar links to Cards > Top Cards
  2. Type your search query
  3. Click "Apply"
  4. Modify filter
  5. Click on "Quick Filter" (whoops)
  6. Click browser Back button, attempting to restore the query

Expected behavior
After pressing back, previous query URL is restored.

Actual behaviour
Navigated to page orignal page before Top Cards

Screenshot

Screenshot from 2024-06-07 09-26-23

Additional context

It might be good to restyle this component slightly - the current UI leads me to clicking "Quick Filter" instead of "Apply" accidentally, because "Apply" is in the top-right, and "Quick Filter" has the same "accent" colour but is in the bottom-right.

Recoloring the "Quick Filter" button color "secondary" instead of "accent" might improve UX.

Could also add Ctrl + Z or similar to recover previous search state here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant