You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Instead, the job attempts to fetch the pretrained model from the current Github repo's URL (https://github.com/my-org/myrepo/releases) , which is non-existent, and returns a 404 Not Found.
Root Cause
Spleeter uses the [following environment variables(https://github.com/deezer/spleeter/blob/master/spleeter/model/provider/github.py#L88-L90) for building the fetch URL for its pre-trained, published models:
GITHUB_HOST
GITHUB_REPOSITORY
GITHUB_RELEASE
Unfortunately, GITHUB_REPOSITORY is a reserved environment variable in the context of Github Actions, and gets picked up at runtime, resulting in an incorrect destination model URL.
Solution Options
One alternative is to explicitly set GITHUB_REPOSITORY at the time of invocation of spleeter.
$ GITHUB_REPOSITORY="deezer/spleeter" poetry run python lib/stem_split.py
However, this could introduce undesired side-effects in the Github Action by overriding what should be the original expected value that's set by the environment by default.
A more appropriate solution would be to make the internal usage of spleeter-specific Github environment variables even more distinct, than the current, generic, conflicting names.
Environment
OS
Linux
Installation type
poetry
RAM available
plenty
Hardware spec
CPU
The text was updated successfully, but these errors were encountered:
chuttam
changed the title
[Bug] Model download models points to wrong location when splitting on Github Actions runner
[Bug] Model download URL points to wrong location when splitting on Github Actions runner
Aug 25, 2022
chuttam
added a commit
to chuttam/spleeter
that referenced
this issue
Aug 25, 2022
When running in a Github Action runner, `GITHUB_REPOSITORY` is a reserved environment variable that ideally should not be overridden for fear of erratic/unexpected side-effects.
This commit renames the environment variables to be a bit more distinct and related to their purpose within spleeter i.e. for building a model download destination.
Fixesdeezer#781
Description
Any attempt to run
spleeter
on a Github Actions runner results in a 404 GET failure at the step for downloading the pre-trained model from spleeter's URL (https://github.com/deezer/spleeter/releases).Instead, the job attempts to fetch the pretrained model from the current Github repo's URL (https://github.com/my-org/myrepo/releases) , which is non-existent, and returns a
404 Not Found
.Root Cause
Spleeter uses the [following environment variables(https://github.com/deezer/spleeter/blob/master/spleeter/model/provider/github.py#L88-L90) for building the fetch URL for its pre-trained, published models:
GITHUB_HOST
GITHUB_REPOSITORY
GITHUB_RELEASE
Unfortunately,
GITHUB_REPOSITORY
is a reserved environment variable in the context of Github Actions, and gets picked up at runtime, resulting in an incorrect destination model URL.Solution Options
One alternative is to explicitly set
GITHUB_REPOSITORY
at the time of invocation of spleeter.However, this could introduce undesired side-effects in the Github Action by overriding what should be the original expected value that's set by the environment by default.
A more appropriate solution would be to make the internal usage of spleeter-specific Github environment variables even more distinct, than the current, generic, conflicting names.
Environment
The text was updated successfully, but these errors were encountered: