Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example is too complex and not complete with regard to dependencies #45

Open
olleharstedt opened this issue Sep 3, 2022 · 6 comments · May be fixed by #46
Open

Example is too complex and not complete with regard to dependencies #45

olleharstedt opened this issue Sep 3, 2022 · 6 comments · May be fixed by #46

Comments

@olleharstedt
Copy link

olleharstedt commented Sep 3, 2022

Had this issue: #18

Had to google to come here.

Wouldn't mind a simpler example... 😅 And please, include the dependencies so I know what to install/include in dune. 👍

@olleharstedt olleharstedt changed the title Example is too complex and not complete with regards to dependencies Example is too complex and not complete with regard to dependencies Sep 3, 2022
@dbuenzli
Copy link
Owner

dbuenzli commented Sep 3, 2022

Which example did you find too complex ? Those in the basics ? I'm not sure I can make them much simpler.

@olleharstedt
Copy link
Author

olleharstedt commented Sep 3, 2022

Hm, no, I ended up at https://erratique.ch/software/logs/doc/Logs_cli/index.html#ex for CLI logging. 🤔

Are you saying

Logs.err (fun m -> m "invalid kv (%a,%a)" pp_key k pp_val v);

works out-of-the-box with only "logs" added to dune config? But where is it logging to, stdout?

@dbuenzli
Copy link
Owner

dbuenzli commented Sep 3, 2022

It will only log when you setup the reporter here

It may be worth giving a full complete simple example. Before the more complex one.

@dbuenzli
Copy link
Owner

dbuenzli commented Sep 3, 2022

It will only log when you setup the reporter here

Well that one also uses one more library… If you only want to use logs you should use this reporter.

Anyways, yes should be improved.

@rbjorklin
Copy link

@olleharstedt I just provided a complete(?) example in #46 please take a look and see if it helps resolve your situation.

@olleharstedt
Copy link
Author

Cool, thanks @rbjorklin :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants