-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bitwarden native mobile clients fail sync with invalid ssh-key entries #5343
Comments
If there are any invalid ssh-key entries this will happen. |
same here on android app --> Version: 2024.12.0 (19597) everything's OK with the desktop app, from where I've added the ssh keys. edit : will have a look at #5322, tomorrow ! |
The mobile clients are more strict. |
yep, saw your previous answer ;) from my Phone, on the web version I'm not able to see any of the ssh key, and the trash is also empty ... weird will check tomorrow if I'm able to see anything from desktop app. |
The web-vault doesn't support this (yet), so that isn't strange. |
If this is happening on both iOS & android, and is all related to ssh keys I’d suggest changing the title of this issue to reflect that. This helps keeps all previous issues of mobile clients not working separate, and specific to the actual issue. |
so indeed I had 2 |
If any of the mandatory ssh-key json data values are not a string or are an empty string, this will break the mobile clients. This commit fixes this by checking if any of the values are missing or invalid and converts the json data to `null`. It will ensure the clients can sync and show the vault. Fixes dani-garcia#5343 Fixes dani-garcia#5322 Signed-off-by: BlackDex <[email protected]>
I have created a fix for this. The only issue is that all the data of the key will be lost if just one of the mandatory fields is missing, as anything other than a valid encrypted string will still break the client. And we can't just replace it with something else. |
Let me hijack this thread a little bit. 1.32.7 server image Couple weeks/month ago there were a similar occasion where it was solved by updating to latest server/client but that does not help now. |
Start a new discussion, post your Support String (generate it via |
* Refactor the uri match change Refactored the uri match fix to also convert numbers within a string to an int. If it fails it will be null. Signed-off-by: BlackDex <[email protected]> * Fix ssh-key sync issues If any of the mandatory ssh-key json data values are not a string or are an empty string, this will break the mobile clients. This commit fixes this by checking if any of the values are missing or invalid and converts the json data to `null`. It will ensure the clients can sync and show the vault. Fixes #5343 Fixes #5322 Signed-off-by: BlackDex <[email protected]> --------- Signed-off-by: BlackDex <[email protected]>
Vaultwarden Support String
Your environment (Generated via diagnostics page)
Vaultwarden Build Version
1.32.7
Deployment method
Official Container Image
Custom deployment method
No response
Reverse Proxy
nginx
Host/Server Operating System
Linux
Operating System Version
Ubuntu 22.04
Clients
iOS
Client Version
2024.12.0 (1740)
Steps To Reproduce
value: ssh-key-vault-item,ssh-agent
Later deleted the variables
Expected Result
The synchronisation was successful
Actual Result
Synchronisation does not work, vault not updated, not loading
Logs
No response
Screenshots or Videos
Additional Context
No response
The text was updated successfully, but these errors were encountered: