Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library is reliant on operator< and operator== #1

Open
dancooke opened this issue Oct 29, 2017 · 1 comment
Open

Library is reliant on operator< and operator== #1

dancooke opened this issue Oct 29, 2017 · 1 comment
Assignees
@dancooke
Labels
enhancement good first issue

Comments

@dancooke
Copy link
Owner

Many of the libraries methods are reliant on both operator<, operator==, and operator!=. Ideally reliance should only be on operator< - in a similar way to std::sort andstd::set. This is annoying as it requires users to define all these operators for Mappable types. Currently the easiest way to do this is to inherit from Comparable and implement operator< and operator==.
@dancooke dancooke self-assigned this Oct 29, 2017
@dancooke
Copy link
Owner Author

Removed dependence on operator!= in this commit.

@dancooke dancooke changed the title Library is reliant on operator<, operator==, operator!= Library is reliant on operator< and operator== Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dancooke dancooke

Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dancooke