You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the shellcheck and checkbashisms step in .github/workflows/test.yml explicitly lists files to check:
- name: Run shellcheckrun: shellcheck wcurl tests/*
- name: Run checkbashismsrun: checkbashisms wcurl tests/*
This approach requires manual updates whenever files are added, renamed, or moved, which can lead to omissions in CI checks.
To improve maintainability, the workflow should dynamically include all relevant files without hardcoding their paths. There is related discussion on this topic in koalaman/shellcheck#143.
Tasks
Research dynamic file inclusion methods compatible with shellcheck and checkbashisms.
Update the workflow to automate file discovery.
Test the updated workflow to ensure all relevant files are checked.
Create a pull request with the enhanced configuration.
Outcome
This enhancement will reduce maintenance overhead and ensure comprehensive CI checks for shell scripts.
The text was updated successfully, but these errors were encountered:
arthurbdiniz
changed the title
Enhance shellcheck and checkbashisms CI to Automatically Include All Relevant Files
Enhance shellcheck and checkbashisms CI to automatically include all relevant files
Dec 9, 2024
Description
Currently, the
shellcheck
andcheckbashisms
step in.github/workflows/test.yml
explicitly lists files to check:This approach requires manual updates whenever files are
added
,renamed
, ormoved
, which can lead to omissions in CI checks.To improve maintainability, the workflow should dynamically include all relevant files without hardcoding their paths. There is related discussion on this topic in koalaman/shellcheck#143.
Tasks
shellcheck
andcheckbashisms
.Outcome
This enhancement will reduce maintenance overhead and ensure comprehensive CI checks for shell scripts.
The text was updated successfully, but these errors were encountered: