Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should trurl normalize the path? #329

Closed
bagder opened this issue Aug 26, 2024 · 0 comments · Fixed by #331
Closed

should trurl normalize the path? #329

bagder opened this issue Aug 26, 2024 · 0 comments · Fixed by #331

Comments

@bagder
Copy link
Member

bagder commented Aug 26, 2024

With #328 merged, trurl does this:

$ trurl 'https://ex%61m%62/p%61%62/?%61=%62'
https://examb/p%61%62/?a=b

Ie, both the hostname and the query part are "normalized". The path is not. Should it be normalized as well?
bagder added a commit that referenced this issue Aug 27, 2024
@bagder
trurl: canonicalize the path
30f0761 
trurl now URL-decodes + URL-encodes the path so that %-sequences that
can be expressed as ASCII are shown as ASCII and %-sequences are unified
to lowercase hex etc.

Added test case to verify

Fixes #329
@bagder bagder mentioned this issue Aug 27, 2024
Merged
bagder added a commit that referenced this issue Aug 27, 2024
@bagder
trurl: canonicalize the path
817c31a 
trurl now URL-decodes + URL-encodes the path so that %-sequences that
can be expressed as ASCII are shown as ASCII and %-sequences are unified
to lowercase hex etc.

Added test case to verify

Fixes #329
Closes #331
bagder added a commit that referenced this issue Aug 27, 2024
@bagder
trurl: canonicalize the path
4e349e6 
trurl now URL-decodes + URL-encodes the path so that %-sequences that
can be expressed as ASCII are shown as ASCII and %-sequences are unified
to lowercase hex etc.

Add test cases to verify

Fixes #329
Closes #331
bagder added a commit that referenced this issue Aug 27, 2024
@bagder
trurl: canonicalize the path
ee9ab20 
trurl now URL-decodes + URL-encodes the path so that %-sequences that
can be expressed as ASCII are shown as ASCII and %-sequences are unified
to lowercase hex etc.

Add test cases to verify

Fixes #329
Closes #331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

trurl: canonicalize the path curl/trurl
1 participant
@bagder