Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"File a bug about this page" links ignore specified title and label #351

Closed
abbeyj opened this issue May 24, 2024 · 6 comments
Closed

"File a bug about this page" links ignore specified title and label #351

abbeyj opened this issue May 24, 2024 · 6 comments

Comments

@abbeyj
Copy link

abbeyj commented May 24, 2024

The documentation pages have links saying "File a bug about this page". For example https://curl.se/libcurl/c/CURLOPT_SSL_VERIFYHOST.html has a link pointing to https://github.com/curl/curl/issues/new?title=CURLOPT_SSL_VERIFYHOST%20man%20page:&labels=documentation .

Unfortunately that URL now redirects to https://github.com/curl/curl/issues/new/choose . Even if you pick the "Bug Report" option from that page, the title of "CURLOPT_SSL_VERIFYHOST man page:" and the label of "documentation" are lost.

Adding &template=bug_report.yml to the end of the URL to produce https://github.com/curl/curl/issues/new?title=CURLOPT_SSL_VERIFYHOST%20man%20page:&labels=documentation&template=bug_report.yml will fix the issue with the title being lost, but it does not fix the label. The fields in this template may not be the most relevant for a documentation-only bug. Perhaps a separate template for documentation bugs would be useful?
@bagder
Copy link
Member

bagder commented Jul 2, 2024

This seems to work fine for me?

@abbeyj
Copy link
Author

abbeyj commented Jul 9, 2024

I can still reproduce. I've tried in both Firefox and Chrome with the same results.

Where do things diverge for you? Do you not get redirected from https://github.com/curl/curl/issues/new?title=CURLOPT_SSL_VERIFYHOST%20man%20page:&labels=documentation to https://github.com/curl/curl/issues/new/choose ? Maybe GitHub treats you differently because you're an owner of the repository?

@bagder
Copy link
Member

bagder commented Jul 11, 2024

Maybe GitHub treats you differently because you're an owner of the repository?

Yeah, I think that might be what's going on...

@bagder
Copy link
Member

bagder commented Jul 11, 2024

Does this link work for you?

https://github.com/curl/curl/issues/new?labels=documentation&template=docs.yml&title=moo

bagder added a commit that referenced this issue Jul 11, 2024
@bagder
links: update the "file a bug" links to include the docs template
1e61cf9 
The previous links stopped working correctly at some point. They would
still end up in the bug tracker but not with the title correctly filled
in and the 'documentation' label set as intended.

This should bring back this feature.

Reported-by: James Abbatiello
Fixes #351
@bagder bagder mentioned this issue Jul 11, 2024
Closed
@abbeyj
Copy link
Author

abbeyj commented Jul 12, 2024

Yes, that link works for me. It looks like this:
image

@bagder
Copy link
Member

bagder commented Jul 12, 2024

Excellent, thanks for testing. I'll merge #364 now which should fix this.

@bagder bagder closed this as completed in e430980 Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

links: update the "file a bug" links to include the docs template curl/curl-www
2 participants
@abbeyj @bagder