Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] consider ability to apply/inject arbitrary patches to recipe without forking repository #17360

Open
1 task done
jcar87 opened this issue Nov 21, 2024 · 1 comment · May be fixed by #17520
Open
1 task done
Assignees

Comments

@jcar87
Copy link
Contributor

jcar87 commented Nov 21, 2024

What is your suggestion?

(placeholder)

Have you read the CONTRIBUTING guide?

  • I've read the CONTRIBUTING guide
@memsharded
Copy link
Member

I have been thinking a bit about this, and I think this is might have some important challenges:

  • being able to inject arbitrary patches is equivalent to modifying conandata.yml on the fly. The same principle could be used to modify also the conandata.yml "sources" origin.
  • This injection, applied to any recipe existing in Conan cache or Conan servers, to build some dependencies injecting patches, means that the recipe-revision is not changed at all, it cannot be changed, as that implies a whole new export
  • If the recipe-revision is not change at all, then there is no traceability, reproducibility or correct package_id computation, changing the applied patches will not trigger a new build, and even if the build was forced it will never know the corresponding source patches that were applied

So the only possibility that I think would make some sense is to have an extra conandata.yml location for conan export/create time from conan-center-index fork, similar to the settings_user.yml approach, when it is possible to load extra patches from another location. But I think this sounds a worse alternative than just adding the patches in the original conandata.yml and have a clear diff. Was this the original idea of this ticket?

@memsharded memsharded linked a pull request Dec 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants