From 4f28dc3aefa12d2b8e0bcf1128d964a00d898ff3 Mon Sep 17 00:00:00 2001
From: Andy Li <1450947+andy1li@users.noreply.github.com>
Date: Mon, 6 Jan 2025 10:06:57 +0800
Subject: [PATCH] feat: Remove feature flag for showing short instructions in
 second stage tutorial card

---
 .../course-stage-step/second-stage-tutorial-card.hbs      | 2 +-
 .../course-stage-step/second-stage-tutorial-card.ts       | 4 ----
 app/services/feature-flags.js                             | 8 --------
 3 files changed, 1 insertion(+), 13 deletions(-)

diff --git a/app/components/course-page/course-stage-step/second-stage-tutorial-card.hbs b/app/components/course-page/course-stage-step/second-stage-tutorial-card.hbs
index 45c232c75..dd0e0f371 100644
--- a/app/components/course-page/course-stage-step/second-stage-tutorial-card.hbs
+++ b/app/components/course-page/course-stage-step/second-stage-tutorial-card.hbs
@@ -1,7 +1,7 @@
 <CoursePage::InstructionsCard @title="How to pass this stage" id="second-stage-tutorial-card" ...attributes>
   <:content>
     <div class="prose dark:prose-invert mb-5">
-      {{#if (and this.shouldShowShortInstructions (eq @repository.course.slug "shell"))}}
+      {{#if (eq @repository.course.slug "shell")}}
         <div class="mb-5 prose-compact">
           {{markdown-to-html @courseStage.shortInstructionsMarkdown}}
         </div>
diff --git a/app/components/course-page/course-stage-step/second-stage-tutorial-card.ts b/app/components/course-page/course-stage-step/second-stage-tutorial-card.ts
index acb028366..90e13033d 100644
--- a/app/components/course-page/course-stage-step/second-stage-tutorial-card.ts
+++ b/app/components/course-page/course-stage-step/second-stage-tutorial-card.ts
@@ -83,10 +83,6 @@ export default class SecondStageTutorialCardComponent extends Component<Signatur
     );
   }
 
-  get shouldShowShortInstructions() {
-    return this.featureFlags.canSeeShortInstructionsForStage2;
-  }
-
   get steps() {
     return [
       new ImplementSolutionStep(this.args.repository, this.implementSolutionStepIsComplete),
diff --git a/app/services/feature-flags.js b/app/services/feature-flags.js
index c3dd77615..4695b8f66 100644
--- a/app/services/feature-flags.js
+++ b/app/services/feature-flags.js
@@ -14,14 +14,6 @@ export default class FeatureFlagsService extends Service {
     return this.currentUser && (this.currentUser.isStaff || this.currentUser.isConceptAuthor);
   }
 
-  get canSeeShortInstructionsForStage2() {
-    return this.currentUser?.isStaff || this.getFeatureFlagValue('can-see-short-instructions-for-stage-2') === 'test';
-  }
-
-  get canSeeTweaksForStage1() {
-    return this.currentUser?.isStaff || this.getFeatureFlagValue('can-see-tweaks-for-stage-1') === 'test';
-  }
-
   get currentUser() {
     return this.authenticator.currentUser;
   }